[KeyVault] Fix #33367 az keyvault show-deleted: Fix keyvault show-deleted missing-arg hint and add regression test#33374
Conversation
Fix keyvault show-deleted missing-arg hint and add regression test Agent-Logs-Url: https://github.com/flcdrg/azure-cli/sessions/3235ca65-38e7-45ad-95d2-b1515574eb7b Co-authored-by: flcdrg <384747+flcdrg@users.noreply.github.com>
flcdrg
requested review from
isra-fel,
notyashhh,
teresaritorto and
xuming-ms
as code owners
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
added
the
customer-reported
|
Thank you for your contribution @flcdrg! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
added
KeyVault
There was a problem hiding this comment.
Pull request overview
This PR fixes the missing-argument error text for deleted Key Vault/HSM validation so az keyvault show-deleted points users to the actual --name option.
Changes:
- Updates the validator error message from
--vault-nameto--name. - Adds a regression unit test for the missing-name validation path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/keyvault/_validators.py |
Corrects the missing-argument hint for deleted vault/HSM commands. |
src/azure-cli/azure/cli/command_modules/keyvault/tests/latest/test_keyvault_validators.py |
Adds unit coverage for the corrected validator message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related command
az keyvault show-deleted
Description
Correct the parameter name returned in error message
Testing Guide
az keyvault show-deleted --query ""Should now return error message mentioning
--nameinstead of--vault-nameThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.
Agent-Logs-Url: https://github.com/flcdrg/azure-cli/sessions/3235ca65-38e7-45ad-95d2-b1515574eb7b
Co-authored-by: flcdrg 384747+flcdrg@users.noreply.github.com