Skip to content

[KeyVault] Fix #33367 az keyvault show-deleted: Fix keyvault show-deleted missing-arg hint and add regression test #33374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
flcdrg wants to merge 1 commit into
base: dev
Choose a base branch
from
+19 −1
Open

[KeyVault] Fix #33367 az keyvault show-deleted: Fix keyvault show-deleted missing-arg hint and add regression test #33374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/keyvault/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ def validate_deleted_vault_or_hsm_name(cmd, ns):
hsm_name = getattr(ns, 'hsm_name', None)

if not vault_name and not hsm_name:
raise CLIError('Please specify --vault-name or --hsm-name.')
raise CLIError('Please specify --name or --hsm-name.')

if vault_name:
resource_name = vault_name
Expand Down
18 changes: 18 additions & 0 deletions src/azure-cli/azure/cli/command_modules/keyvault/tests/latest/test_keyvault_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# --------------------------------------------------------------------------------------------
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License. See License.txt in the project root for license information.
# --------------------------------------------------------------------------------------------

import argparse
from unittest import TestCase, mock

from knack.util import CLIError


class DeletedVaultOrHsmValidatorTest(TestCase):
def test_validate_deleted_vault_or_hsm_name_without_name(self):
from azure.cli.command_modules.keyvault._validators import validate_deleted_vault_or_hsm_name

ns = argparse.Namespace(vault_name=None, hsm_name=None)
with self.assertRaisesRegex(CLIError, 'Please specify --name or --hsm-name.'):
validate_deleted_vault_or_hsm_name(mock.Mock(), ns)
Loading