Rename parameter trust to requireApproval. #53371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames the trust parameter to requireApproval in the MCPApproval constructor to improve clarity and better reflect the parameter's purpose.
- Renamed constructor parameter from
trusttorequireApproval - Updated parameter documentation to reflect the new name
- Added changelog entry documenting this breaking change
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/ai/Azure.AI.Agents.Persistent/src/Custom/MCPApproval.cs | Renamed constructor parameter from trust to requireApproval and updated internal references |
| sdk/ai/Azure.AI.Agents.Persistent/CHANGELOG.md | Added breaking change entry for the parameter rename |
nick863
force-pushed
the
nirovins/rename_trust_parameter
branch
from
31592df to
b20ab70
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
nick863
force-pushed
the
nirovins/rename_trust_parameter
branch
from
b20ab70 to
10af40b
Compare
dargilco
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
#53000
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.