Skip to content

Rename parameter trust to requireApproval. #53371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

Rename parameter trust to requireApproval. #53371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/ai/Azure.AI.Agents.Persistent/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Features Added

### Breaking Changes
- The `trust` parameter for `MCPApproval` constructor was renamed to `requireApproval`.

### Bugs Fixed

Expand Down
2 changes: 1 addition & 1 deletion sdk/ai/Azure.AI.Agents.Persistent/api/Azure.AI.Agents.Persistent.net8.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ protected override void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter write
public partial class MCPApproval
{
public MCPApproval(Azure.AI.Agents.Persistent.MCPApprovalPerTool perToolApproval) { }
public MCPApproval(string trust) { }
public MCPApproval(string requireApproval) { }
public bool AlwaysRequireApproval { get { throw null; } }
public bool NeverRequireApproval { get { throw null; } }
public Azure.AI.Agents.Persistent.MCPApprovalPerTool PerToolApproval { get { throw null; } }
Expand Down
2 changes: 1 addition & 1 deletion sdk/ai/Azure.AI.Agents.Persistent/api/Azure.AI.Agents.Persistent.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ protected override void JsonModelWriteCore(System.Text.Json.Utf8JsonWriter write
public partial class MCPApproval
{
public MCPApproval(Azure.AI.Agents.Persistent.MCPApprovalPerTool perToolApproval) { }
public MCPApproval(string trust) { }
public MCPApproval(string requireApproval) { }
public bool AlwaysRequireApproval { get { throw null; } }
public bool NeverRequireApproval { get { throw null; } }
public Azure.AI.Agents.Persistent.MCPApprovalPerTool PerToolApproval { get { throw null; } }
Expand Down
10 changes: 5 additions & 5 deletions sdk/ai/Azure.AI.Agents.Persistent/src/Custom/MCPApproval.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ public MCPApproval(MCPApprovalPerTool perToolApproval)
/// <summary>
/// Create an instance of an MCPApproval with trust level, equal for all tools.
/// </summary>
/// <param name="trust">The trust level, can be "always" or "never"</param>
public MCPApproval(string trust)
/// <param name="requireApproval">The approval requirement, can be "always" or "never"</param>
public MCPApproval(string requireApproval)
{
if (!string.Equals(trust, ALWAYS) && !string.Equals(trust, NEVER))
throw new ArgumentException($"The parameter \"trust\" may be only \"{ALWAYS}\" or \"{NEVER}\".");
_forAllToolsApproval = trust;
if (!string.Equals(requireApproval, ALWAYS) && !string.Equals(requireApproval, NEVER))
throw new ArgumentException($"The parameter \"requireApproval\" may be only \"{ALWAYS}\" or \"{NEVER}\".");
_forAllToolsApproval = requireApproval;
}
/// <summary>
/// Return true if we do not trust all tools and always need to ask for approval before sending data to server.
Expand Down
3 changes: 1 addition & 2 deletions sdk/ai/Azure.AI.Agents.Persistent/tests/UnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
using System;
using System.Collections.Generic;
using System.Text;
using Microsoft.AspNetCore.Hosting.Server;
using NUnit.Framework;

namespace Azure.AI.Agents.Persistent.Tests
Expand Down Expand Up @@ -43,7 +42,7 @@ public void MCPApprovalPerTool()
public void MCPApprovalRaisesString()
{
ArgumentException exc = Assert.Throws<ArgumentException>(() => new MCPApproval("test"));
Assert.That(exc.Message.StartsWith("The parameter \"trust\" may be only \"always\" or \"never\"."), $"Unexpected message {exc.Message}");
Assert.That(exc.Message.StartsWith("The parameter \"requireApproval\" may be only \"always\" or \"never\"."), $"Unexpected message {exc.Message}");
}

[Test]
Expand Down