Suppress unnecessary "failed to get id for item" errors - #3339
Open
jordanbrymora wants to merge 6 commits into
Open
Suppress unnecessary "failed to get id for item" errors#3339jordanbrymora wants to merge 6 commits into
jordanbrymora wants to merge 6 commits into
Conversation
garrettluskey
requested changes
Aug 25, 2026
garrettluskey
left a comment
garrettluskey
left a comment
Contributor
There was a problem hiding this comment.
the empty roster-slot diagnosis is right, but the unresolved scope issue in the existing thread still needs to be fixed before this can go in.
garrettluskey
requested changes
Aug 25, 2026
Co-authored-by: Garrett Luskey <garrett.luskey@gmail.com>
garrettluskey
requested changes
Aug 25, 2026
garrettluskey
left a comment
garrettluskey
left a comment
Contributor
There was a problem hiding this comment.
the empty roster-slot diagnosis is right. this still leaves the noisy path unchanged, so changes are needed before this fixes the reported error.
garrettluskey
requested changes
Aug 26, 2026
garrettluskey
left a comment
garrettluskey
left a comment
Contributor
There was a problem hiding this comment.
Switching the discard path from the backing array to the roster's active range fixes the noisy default tail-slot case. Changes are still needed because the new caller-side guards also suppress real resolution failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
TradeHandler.TryResolveItemRosterIdoutputs an error when it fails to resolve the id of an item. The problem is that anItemRostercan have emptyItemRosterElements with null item values.What is the new behavior?
Add an earlier check to return if the item in the
ItemRosterElementis null to avoid logging unnecessary errors.