Skip to content

Suppress unnecessary "failed to get id for item" errors #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanbrymora wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Suppress unnecessary "failed to get id for item" errors #3339

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b196d9
Suppress "failed to get id for item" errors
jordanbrymora Aug 25, 2026
740686f
Apply suggestions from code review
jordanbrymora Aug 25, 2026
b06751f
Fix
jordanbrymora Aug 25, 2026
2e7d0c7
Remove unused import
jordanbrymora Aug 25, 2026
8d5f3c5
Review comment
jordanbrymora Aug 26, 2026
21f8ca2
Merge branch 'development' into SuppressFailedItemIdErrors
jordanbrymora Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions source/GameInterface/Services/Inventory/Handlers/TradeHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ private void Handle_TradeAttempted(MessagePayload<TradeAttempted> payload)

if (what.CanGainXpFromDiscarding)
{
soldItems = ResolveLeftLootIds(what.FromRoster._data);
soldItems = ResolveLeftLootIds(what.FromRoster);
}

var characterIdEquipmentsData = ResolveCharacterIdEquipmentsData(what.OwnerParty, what.InitialCharacterEquipment);
Expand Down Expand Up @@ -231,6 +231,9 @@ private void Handle_UpdateEquipmentClients(MessagePayload<UpdateEquipmentClients

foreach (var (item, count) in items)
{
if (item.EquipmentElement.Item == null)
Comment thread
jordanbrymora marked this conversation as resolved.
Comment thread
jordanbrymora marked this conversation as resolved.
continue;

if (TryResolveItemRosterId(item, out var resolvedItem))
{
resolvedItems.Add((resolvedItem, count));
Expand All @@ -240,15 +243,20 @@ private void Handle_UpdateEquipmentClients(MessagePayload<UpdateEquipmentClients
return resolvedItems.ToArray();
}

private (ItemRosterElementData, int)[] ResolveLeftLootIds(ItemRosterElement[] items)
private (ItemRosterElementData, int)[] ResolveLeftLootIds(ItemRoster discardedItems)
{
var resolvedItems = new List<(ItemRosterElementData, int)>();

for (int i = 0; i < items.Length; i++)
for (int i = 0; i < discardedItems.Count; i++)
{
if (TryResolveItemRosterId(items[i], out var resolvedItem))
var item = discardedItems.GetElementCopyAtIndex(i);

if (item.EquipmentElement.Item == null)
continue;

if (TryResolveItemRosterId(item, out var resolvedItem))
{
resolvedItems.Add((resolvedItem, items[i].Amount));
resolvedItems.Add((resolvedItem, item.Amount));
}
}

Expand Down
Loading