qt: fix support for Wayland on linux #3230
Merged
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately the Comments before the `-extra-plugins` without line-break delimiter made it a separate command. The `-` in Makefile means `extra-plugins` is executed ignoring errors. This combination made CI pass without Wayland plugins actually being deployed. Fixes BitBoxSwiss#3229.
Merged
Beerosagos
requested changes
Mar 12, 2025
There was a problem hiding this comment.
I think you missed updating the version in some other places too (see eg f3f3d12)
Nvm, as we discussed this is only going to be released as a Linux hotfix, so everything is good
Beerosagos
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the Comments before the
-extra-pluginswithout line-break delimiter made it a separate command. The-in Makefile meansextra-pluginsis executed ignoring errors. This combination made CI pass without Wayland plugins actually being deployed.Fixes #3229.