Skip to content

Conversation

@mart-r
Copy link
Collaborator

@mart-r mart-r commented Oct 29, 2025

Looks like both #167 and #171 added these lines and they now appeared duplicated in pyproject.toml. This PR removes the duplicates.

Looks like both #167 and #171 added these lines and they now appeared duplicated in pyproject.toml.
This PR removes the duplicates.
@tomolopolis
Copy link
Member

Copy link
Collaborator

@alhendrickson alhendrickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

deid = [
"datasets>=2.2.2,<3.0.0",
# Transformers 4.57 doesn't support 3.9
"transformers!=4.57.0; python_version == '3.9'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a loose thought, could you even remove the non-duplicated line now? If we don't specifically support 3.9 anymore. May as well keep it I guess just a thought.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good shout!

Copy link
Collaborator

@alhendrickson alhendrickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mart-r mart-r merged commit 92021a3 into main Oct 29, 2025
20 checks passed
@mart-r mart-r deleted the build/medcat/CU-869azvxkn-fix-duplicate-deps branch October 29, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants