Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MemberNotNull to fix build #6699

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Remove MemberNotNull to fix build #6699

merged 1 commit into from
Feb 21, 2025

Conversation

bouwkast
Copy link
Contributor

Summary of changes

Updated VS and MSBuild locally and can no longer build.

Reason for change

Build wasn't working and I think these are covered as we have nullable enabled and MetricsHostname is get only

Implementation details

Delete

Test coverage

Build works now

Other details

@bouwkast bouwkast requested a review from a team as a code owner February 21, 2025 15:17
@github-actions github-actions bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Feb 21, 2025
Copy link
Member

@andrewlock andrewlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6699) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (70ms)  : 65, 75
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (6699) - mean (995ms)  : 967, 1024
     .   : milestone, 995,
    master - mean (1,001ms)  : 976, 1025
     .   : milestone, 1001,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6699) - mean (102ms)  : 100, 104
     .   : milestone, 102,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6699) - mean (667ms)  : 647, 687
     .   : milestone, 667,
    master - mean (725ms)  : 664, 787
     .   : milestone, 725,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6699) - mean (89ms)  : 86, 91
     .   : milestone, 89,
    master - mean (100ms)  : 92, 109
     .   : milestone, 100,

    section CallTarget+Inlining+NGEN
    This PR (6699) - mean (622ms)  : 606, 638
     .   : milestone, 622,
    master - mean (690ms)  : 654, 726
     .   : milestone, 690,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6699) - mean (192ms)  : 187, 196
     .   : milestone, 192,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6699) - mean (1,110ms)  : 1069, 1151
     .   : milestone, 1110,
    master - mean (1,106ms)  : 1081, 1132
     .   : milestone, 1106,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6699) - mean (272ms)  : 267, 276
     .   : milestone, 272,
    master - mean (270ms)  : 266, 275
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (6699) - mean (867ms)  : 836, 899
     .   : milestone, 867,
    master - mean (865ms)  : 835, 894
     .   : milestone, 865,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6699) - mean (262ms)  : 258, 266
     .   : milestone, 262,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6699) - mean (841ms)  : 810, 871
     .   : milestone, 841,
    master - mean (847ms)  : 813, 881
     .   : milestone, 847,

Loading

@bouwkast bouwkast merged commit 9657cae into master Feb 21, 2025
141 of 146 checks passed
@bouwkast bouwkast deleted the steven/fix-build branch February 21, 2025 19:26
@github-actions github-actions bot added this to the vNext-v3 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants