Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MemberNotNull to fix build #6699

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Remove MemberNotNull to fix build #6699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tracer/src/Datadog.Trace/Configuration/ExporterSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,6 @@ bool TryGetMetricsUriAndTransport(string metricsUrl, out MetricsTransportSetting
}

#if NETCOREAPP3_1_OR_GREATER
[MemberNotNull(nameof(MetricsHostname))]
bool SetUds(string unixSocket, string original, string absoluteUri, string? source, out MetricsTransportSettings settings)
{
// Only called in the constructor;
Expand All @@ -385,7 +384,6 @@ bool SetUds(string unixSocket, string original, string absoluteUri, string? sour
return probablyValid;
}
#endif
[MemberNotNull(nameof(MetricsHostname))]
bool SetUdp(string hostname, string? hostnameSource, int port, string? portSource, out MetricsTransportSettings settings)
{
var probablyValid = true;
Expand Down
Loading