-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating new feature flag for breaking changes #8379
Draft
mhlidd
wants to merge
1
commit into
master
Choose a base branch
from
mhlidd/breaking_change_flag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~30b752de5d, baseline=1.47.0-SNAPSHOT~3fd5db0dc1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048839
Total [baseline] (10.475 s) : 0, 10475192
Agent [candidate] (1.045 s) : 0, 1045362
Total [candidate] (10.47 s) : 0, 10470270
section appsec
Agent [baseline] (1.191 s) : 0, 1190765
Total [baseline] (10.744 s) : 0, 10743974
Agent [candidate] (1.187 s) : 0, 1187102
Total [candidate] (10.803 s) : 0, 10803079
section iast
Agent [baseline] (1.176 s) : 0, 1175560
Total [baseline] (11.032 s) : 0, 11032301
Agent [candidate] (1.173 s) : 0, 1173373
Total [candidate] (11.01 s) : 0, 11010186
section profiling
Agent [baseline] (1.271 s) : 0, 1271154
Total [baseline] (10.898 s) : 0, 10897966
Agent [candidate] (1.271 s) : 0, 1270624
Total [candidate] (10.92 s) : 0, 10919616
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~30b752de5d, baseline=1.47.0-SNAPSHOT~3fd5db0dc1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.892 ms) : 0, 721892
BytebuddyAgent [candidate] (720.858 ms) : 0, 720858
GlobalTracer [baseline] (241.806 ms) : 0, 241806
GlobalTracer [candidate] (242.28 ms) : 0, 242280
AppSec [baseline] (55.874 ms) : 0, 55874
AppSec [candidate] (55.571 ms) : 0, 55571
Remote Config [baseline] (722.678 µs) : 0, 723
Remote Config [candidate] (733.772 µs) : 0, 734
Telemetry [baseline] (13.21 ms) : 0, 13210
Telemetry [candidate] (10.751 ms) : 0, 10751
section appsec
BytebuddyAgent [baseline] (738.675 ms) : 0, 738675
BytebuddyAgent [candidate] (736.295 ms) : 0, 736295
GlobalTracer [baseline] (239.187 ms) : 0, 239187
GlobalTracer [candidate] (238.57 ms) : 0, 238570
AppSec [baseline] (177.62 ms) : 0, 177620
AppSec [candidate] (176.82 ms) : 0, 176820
Remote Config [baseline] (662.125 µs) : 0, 662
Remote Config [candidate] (663.159 µs) : 0, 663
Telemetry [baseline] (8.33 ms) : 0, 8330
Telemetry [candidate] (8.741 ms) : 0, 8741
IAST [baseline] (21.877 ms) : 0, 21877
IAST [candidate] (21.516 ms) : 0, 21516
section iast
BytebuddyAgent [baseline] (837.75 ms) : 0, 837750
BytebuddyAgent [candidate] (836.867 ms) : 0, 836867
GlobalTracer [baseline] (233.024 ms) : 0, 233024
GlobalTracer [candidate] (231.56 ms) : 0, 231560
AppSec [baseline] (57.212 ms) : 0, 57212
AppSec [candidate] (57.247 ms) : 0, 57247
Remote Config [baseline] (628.975 µs) : 0, 629
Remote Config [candidate] (631.986 µs) : 0, 632
Telemetry [baseline] (8.865 ms) : 0, 8865
Telemetry [candidate] (8.864 ms) : 0, 8864
IAST [baseline] (22.836 ms) : 0, 22836
IAST [candidate] (22.911 ms) : 0, 22911
section profiling
BytebuddyAgent [baseline] (713.263 ms) : 0, 713263
BytebuddyAgent [candidate] (711.282 ms) : 0, 711282
GlobalTracer [baseline] (352.76 ms) : 0, 352760
GlobalTracer [candidate] (354.583 ms) : 0, 354583
AppSec [baseline] (55.878 ms) : 0, 55878
AppSec [candidate] (55.29 ms) : 0, 55290
Remote Config [baseline] (718.782 µs) : 0, 719
Remote Config [candidate] (707.045 µs) : 0, 707
Telemetry [baseline] (8.963 ms) : 0, 8963
Telemetry [candidate] (8.954 ms) : 0, 8954
ProfilingAgent [baseline] (96.847 ms) : 0, 96847
ProfilingAgent [candidate] (97.176 ms) : 0, 97176
Profiling [baseline] (96.871 ms) : 0, 96871
Profiling [candidate] (97.2 ms) : 0, 97200
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~30b752de5d, baseline=1.47.0-SNAPSHOT~3fd5db0dc1
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041904
Total [baseline] (8.662 s) : 0, 8661735
Agent [candidate] (1.041 s) : 0, 1041230
Total [candidate] (8.663 s) : 0, 8662555
section iast
Agent [baseline] (1.17 s) : 0, 1169769
Total [baseline] (9.238 s) : 0, 9238093
Agent [candidate] (1.18 s) : 0, 1180381
Total [candidate] (9.247 s) : 0, 9247091
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171845
Total [baseline] (9.188 s) : 0, 9188097
Agent [candidate] (1.18 s) : 0, 1180394
Total [candidate] (9.226 s) : 0, 9226196
section iast_TELEMETRY_OFF
Agent [baseline] (1.167 s) : 0, 1166905
Total [baseline] (9.229 s) : 0, 9228898
Agent [candidate] (1.176 s) : 0, 1175875
Total [candidate] (9.258 s) : 0, 9258011
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~30b752de5d, baseline=1.47.0-SNAPSHOT~3fd5db0dc1
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.563 ms) : 0, 717563
BytebuddyAgent [candidate] (717.932 ms) : 0, 717932
GlobalTracer [baseline] (241.194 ms) : 0, 241194
GlobalTracer [candidate] (241.222 ms) : 0, 241222
AppSec [baseline] (55.834 ms) : 0, 55834
AppSec [candidate] (55.544 ms) : 0, 55544
Remote Config [baseline] (720.904 µs) : 0, 721
Remote Config [candidate] (713.722 µs) : 0, 714
Telemetry [baseline] (11.435 ms) : 0, 11435
Telemetry [candidate] (10.706 ms) : 0, 10706
section iast
BytebuddyAgent [baseline] (834.355 ms) : 0, 834355
BytebuddyAgent [candidate] (842.762 ms) : 0, 842762
GlobalTracer [baseline] (230.902 ms) : 0, 230902
GlobalTracer [candidate] (232.683 ms) : 0, 232683
IAST [baseline] (22.878 ms) : 0, 22878
IAST [candidate] (23.606 ms) : 0, 23606
AppSec [baseline] (56.888 ms) : 0, 56888
AppSec [candidate] (56.371 ms) : 0, 56371
Remote Config [baseline] (619.24 µs) : 0, 619
Remote Config [candidate] (621.747 µs) : 0, 622
Telemetry [baseline] (8.803 ms) : 0, 8803
Telemetry [candidate] (8.866 ms) : 0, 8866
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.464 ms) : 0, 835464
BytebuddyAgent [candidate] (842.252 ms) : 0, 842252
GlobalTracer [baseline] (231.659 ms) : 0, 231659
GlobalTracer [candidate] (233.264 ms) : 0, 233264
IAST [baseline] (22.862 ms) : 0, 22862
IAST [candidate] (23.096 ms) : 0, 23096
AppSec [baseline] (57.235 ms) : 0, 57235
AppSec [candidate] (57.035 ms) : 0, 57035
Remote Config [baseline] (617.006 µs) : 0, 617
Remote Config [candidate] (612.665 µs) : 0, 613
Telemetry [baseline] (8.702 ms) : 0, 8702
Telemetry [candidate] (8.735 ms) : 0, 8735
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.854 ms) : 0, 831854
BytebuddyAgent [candidate] (838.155 ms) : 0, 838155
GlobalTracer [baseline] (230.923 ms) : 0, 230923
GlobalTracer [candidate] (233.255 ms) : 0, 233255
IAST [baseline] (24.67 ms) : 0, 24670
IAST [candidate] (26.323 ms) : 0, 26323
AppSec [baseline] (54.986 ms) : 0, 54986
AppSec [candidate] (53.455 ms) : 0, 53455
Remote Config [baseline] (630.586 µs) : 0, 631
Remote Config [candidate] (622.115 µs) : 0, 622
Telemetry [baseline] (8.6 ms) : 0, 8600
Telemetry [candidate] (8.693 ms) : 0, 8693
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~30b752de5d, baseline=1.47.0-SNAPSHOT~3fd5db0dc1
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1373
. : milestone, 1353,
appsec (1.756 ms) : 1732, 1780
. : milestone, 1756,
appsec_no_iast (1.756 ms) : 1730, 1782
. : milestone, 1756,
iast (1.503 ms) : 1478, 1529
. : milestone, 1503,
profiling (1.572 ms) : 1548, 1596
. : milestone, 1572,
tracing (1.484 ms) : 1459, 1508
. : milestone, 1484,
section candidate
no_agent (1.352 ms) : 1332, 1371
. : milestone, 1352,
appsec (1.765 ms) : 1741, 1788
. : milestone, 1765,
appsec_no_iast (1.753 ms) : 1730, 1777
. : milestone, 1753,
iast (1.522 ms) : 1498, 1547
. : milestone, 1522,
profiling (1.568 ms) : 1544, 1592
. : milestone, 1568,
tracing (1.503 ms) : 1479, 1527
. : milestone, 1503,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~30b752de5d, baseline=1.47.0-SNAPSHOT~3fd5db0dc1
dateFormat X
axisFormat %s
section baseline
no_agent (383.87 µs) : 364, 403
. : milestone, 384,
iast (518.335 µs) : 496, 540
. : milestone, 518,
iast_FULL (747.613 µs) : 726, 769
. : milestone, 748,
iast_GLOBAL (558.064 µs) : 536, 580
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (511.2 µs) : 489, 533
. : milestone, 511,
iast_INACTIVE (460.613 µs) : 438, 483
. : milestone, 461,
iast_TELEMETRY_OFF (503.335 µs) : 480, 527
. : milestone, 503,
tracing (461.798 µs) : 441, 483
. : milestone, 462,
section candidate
no_agent (375.829 µs) : 356, 396
. : milestone, 376,
iast (515.912 µs) : 494, 538
. : milestone, 516,
iast_FULL (756.762 µs) : 734, 780
. : milestone, 757,
iast_GLOBAL (559.791 µs) : 538, 581
. : milestone, 560,
iast_HARDCODED_SECRET_DISABLED (512.788 µs) : 491, 535
. : milestone, 513,
iast_INACTIVE (466.45 µs) : 445, 488
. : milestone, 466,
iast_TELEMETRY_OFF (505.421 µs) : 482, 529
. : milestone, 505,
tracing (463.458 µs) : 443, 484
. : milestone, 463,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~30b752de5d, baseline=1.47.0-SNAPSHOT~3fd5db0dc1
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.362 ms) : 2319, 2405
. : milestone, 2362,
iast (2.108 ms) : 2054, 2163
. : milestone, 2108,
iast_GLOBAL (2.149 ms) : 2094, 2205
. : milestone, 2149,
profiling (1.955 ms) : 1912, 1998
. : milestone, 1955,
tracing (1.946 ms) : 1904, 1988
. : milestone, 1946,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (2.361 ms) : 2318, 2404
. : milestone, 2361,
iast (2.113 ms) : 2057, 2168
. : milestone, 2113,
iast_GLOBAL (2.155 ms) : 2099, 2210
. : milestone, 2155,
profiling (1.993 ms) : 1948, 2037
. : milestone, 1993,
tracing (1.94 ms) : 1898, 1982
. : milestone, 1940,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~30b752de5d, baseline=1.47.0-SNAPSHOT~3fd5db0dc1
dateFormat X
axisFormat %s
section baseline
no_agent (15.227 s) : 15227000, 15227000
. : milestone, 15227000,
appsec (14.818 s) : 14818000, 14818000
. : milestone, 14818000,
iast (18.88 s) : 18880000, 18880000
. : milestone, 18880000,
iast_GLOBAL (18.113 s) : 18113000, 18113000
. : milestone, 18113000,
profiling (14.827 s) : 14827000, 14827000
. : milestone, 14827000,
tracing (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
section candidate
no_agent (15.604 s) : 15604000, 15604000
. : milestone, 15604000,
appsec (14.923 s) : 14923000, 14923000
. : milestone, 14923000,
iast (18.956 s) : 18956000, 18956000
. : milestone, 18956000,
iast_GLOBAL (18.332 s) : 18332000, 18332000
. : milestone, 18332000,
profiling (15.622 s) : 15622000, 15622000
. : milestone, 15622000,
tracing (15.145 s) : 15145000, 15145000
. : milestone, 15145000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]