Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating new feature flag for breaking changes #8379

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ public final class ConfigDefaults {

static final boolean DEFAULT_LOGS_INJECTION_ENABLED = true;

static final boolean DEFAULT_BREAKING_CHANGES_ENABLED = true;

static final String DEFAULT_APPSEC_ENABLED = "inactive";
static final boolean DEFAULT_APPSEC_REPORTING_INBAND = false;
static final int DEFAULT_APPSEC_TRACE_RATE_LIMIT = 100;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ public final class TraceInstrumentationConfig {
public static final String LOGS_INJECTION_ENABLED = "logs.injection.enabled";
public static final String LOGS_INJECTION = "logs.injection";

public static final String BREAKING_CHANGES_ENABLED = "breaking.changes.enabled";

public static final String TRACE_128_BIT_TRACEID_LOGGING_ENABLED =
"trace.128.bit.traceid.logging.enabled";

Expand Down
10 changes: 10 additions & 0 deletions internal-api/src/main/java/datadog/trace/api/Config.java
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ public static String getHostName() {
private final boolean tracePropagationExtractFirst;
private final int clockSyncPeriod;
private final boolean logsInjectionEnabled;
private final boolean breakingChangesEnabled;

private final String dogStatsDNamedPipe;
private final int dogStatsDStartDelay;
Expand Down Expand Up @@ -1007,6 +1008,9 @@ private Config(final ConfigProvider configProvider, final InstrumenterConfig ins
configProvider.getBoolean(
LOGS_INJECTION_ENABLED, DEFAULT_LOGS_INJECTION_ENABLED, LOGS_INJECTION);

breakingChangesEnabled =
configProvider.getBoolean(BREAKING_CHANGES_ENABLED, DEFAULT_BREAKING_CHANGES_ENABLED);

dogStatsDNamedPipe = configProvider.getString(DOGSTATSD_NAMED_PIPE);

dogStatsDStartDelay =
Expand Down Expand Up @@ -2352,6 +2356,10 @@ public boolean isLogsInjectionEnabled() {
return logsInjectionEnabled;
}

public boolean isBreakingChangesEnabled() {
return breakingChangesEnabled;
}

public boolean isReportHostName() {
return reportHostName;
}
Expand Down Expand Up @@ -4656,6 +4664,8 @@ public String toString() {
+ injectBaggageAsTagsEnabled
+ ", logsInjectionEnabled="
+ logsInjectionEnabled
+ ", breakingChangesEnabled="
+ breakingChangesEnabled
+ ", sparkTaskHistogramEnabled="
+ sparkTaskHistogramEnabled
+ ", sparkAppNameAsService="
Expand Down
Loading