Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(django): update some stale skipped tests in the django suite #12474

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

emmettbutler
Copy link
Collaborator

@emmettbutler emmettbutler commented Feb 21, 2025

This change removes the @flaky markers from some django tests and updates expectations that had become stale.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 21, 2025
@emmettbutler emmettbutler requested review from a team as code owners February 21, 2025 17:25
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/contrib/django/test_django.py                                     @DataDog/apm-core-python @DataDog/apm-idm-python
tests/contrib/django/test_django_snapshots.py                           @DataDog/apm-core-python @DataDog/apm-idm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_psycopg2_query_default.json  @DataDog/apm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_psycopg3_query_default.json  @DataDog/apm-python
tests/snapshots/tests.contrib.django.test_django_snapshots.test_urlpatterns_include.json  @DataDog/apm-python

@erikayasuda
Copy link
Contributor

@emmettbutler It's failing the style check because the flaky import is still there but unused

@emmettbutler emmettbutler enabled auto-merge (squash) February 21, 2025 17:43
@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2025

Benchmarks

Benchmark execution time: 2025-02-21 19:33:35

Comparing candidate commit 8f8021d in PR branch emmett.butler/django-stale with baseline commit 7011d3c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

@emmettbutler emmettbutler merged commit 0249aa7 into main Feb 21, 2025
318 of 322 checks passed
@emmettbutler emmettbutler deleted the emmett.butler/django-stale branch February 21, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants