[manual-container-metrics] Update dependencies, align with OTel/DD be…#175
Draft
[manual-container-metrics] Update dependencies, align with OTel/DD be…#175
Conversation
…st practices - Update Go OTel SDK from v1.18.0 to v1.40.0 (latest stable) - Update otelhttp from v0.44.0 to v0.65.0 - Update Go version from 1.20 to 1.24 - Change metric instruments from UpDownCounter to Gauge (correct OTel instrument for point-in-time container resource measurements) - Add metric descriptions and units per OTel semantic conventions - Add proper error handling throughout (return errors instead of swallowing them) - Add graceful shutdown with signal handling (SIGINT/SIGTERM) - Add HTTP server timeouts (read/write/idle) - Add /health endpoint for basic health checks - Add startup probe in Kubernetes manifest - Use multi-stage Docker build with distroless base image - Add pod and container security context (non-root, read-only FS, drop all capabilities) - Right-size resource requests/limits (100m/128Mi to 500m/256Mi) - Add comments documenting Datadog metric name mapping - Add OTel resource creation with semconv service.name - Remove unused go.uber.org/zap dependency - Document environment variables, endpoints, and metrics in README Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…st practices
What does this PR do?
Motivation