-
Notifications
You must be signed in to change notification settings - Fork 14
Cbeauchesne/debugger follow up #5576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tylfin
approved these changes
Oct 22, 2025
|
If you don't mind, I prefer to not enable auto-merge. The issue on java requires several call to be sure we're not pushing a flake. |
|
@cbeauchesne I pushed a commit, I think we caught an actual regression in the Node.js tracer EDIT: The Java flakiness was due to the test requiring the agent version >= 7.72.0, with that restriction this should be good to merge whenever. |
733ba95 to
4beaf59
Compare
6 tasks
29c2bb8 to
3b1e64e
Compare
jpbempel
approved these changes
Oct 23, 2025
cbeauchesne
commented
Oct 23, 2025
cbeauchesne
commented
Oct 23, 2025
fix(debugger): require agent 7.72.0 great for endpoint test
1a6980c to
9423411
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR re-introduce changes I've reverted this morning :
/debugger/v2/input#5567Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present