Skip to content

Conversation

@cbeauchesne
Copy link
Collaborator

@cbeauchesne cbeauchesne commented Oct 22, 2025

Motivation

This PR re-introduce changes I've reverted this morning :

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/debugger/test_debugger_probe_snapshot.py                          @DataDog/debugger @DataDog/system-tests-core
tests/debugger/utils/probes/probe_snapshot_log_line.json                @DataDog/debugger @DataDog/system-tests-core

@tylfin tylfin marked this pull request as ready for review October 22, 2025 12:49
@tylfin tylfin requested review from a team as code owners October 22, 2025 12:49
@tylfin tylfin enabled auto-merge (squash) October 22, 2025 12:49
@cbeauchesne
Copy link
Collaborator Author

If you don't mind, I prefer to not enable auto-merge. The issue on java requires several call to be sure we're not pushing a flake.

@cbeauchesne cbeauchesne disabled auto-merge October 22, 2025 15:07
@tylfin
Copy link
Member

tylfin commented Oct 22, 2025

@cbeauchesne I pushed a commit, I think we caught an actual regression in the Node.js tracer

EDIT: The Java flakiness was due to the test requiring the agent version >= 7.72.0, with that restriction this should be good to merge whenever.

@tylfin tylfin force-pushed the cbeauchesne/debugger-follow-up branch 2 times, most recently from 733ba95 to 4beaf59 Compare October 22, 2025 16:37
@tylfin tylfin force-pushed the cbeauchesne/debugger-follow-up branch 3 times, most recently from 29c2bb8 to 3b1e64e Compare October 22, 2025 18:54
@tylfin tylfin force-pushed the cbeauchesne/debugger-follow-up branch from 1a6980c to 9423411 Compare October 23, 2025 12:55
@tylfin tylfin merged commit e23ac10 into main Oct 23, 2025
398 checks passed
@tylfin tylfin deleted the cbeauchesne/debugger-follow-up branch October 23, 2025 14:16
@watson watson mentioned this pull request Oct 24, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants