Skip to content

Bump to version 0.27.0 - #17

Open
bragboy wants to merge 2 commits into
DevicoSolutions:masterfrom
bragboy:master
Open

Bump to version 0.27.0#17
bragboy wants to merge 2 commits into
DevicoSolutions:masterfrom
bragboy:master

Conversation

@bragboy

@bragboy bragboy commented Aug 27, 2020

Copy link
Copy Markdown

With the recent upgrade to Firefox 80, this P1 bug seems to be causing failures in some test runs. This will help resolve that failure.

@bragboy
bragboy marked this pull request as ready for review August 27, 2020 15:06
@tuxayo

tuxayo commented Sep 1, 2020

Copy link
Copy Markdown

0.27.0 or rather 0.26.0? Because v0.26.0 should also support Firefox ESR

I just tested locally and v0.26.0 also works with Firefox 80.

Though Firefox ESR users can force geckodriver-helper v0.24.0

@parndt

parndt commented Sep 10, 2020

Copy link
Copy Markdown

Thank you @bragboy this solves the problem for me completely

@hunterae

Copy link
Copy Markdown

Solves for me as well.

@kovpack

kovpack commented Sep 23, 2020

Copy link
Copy Markdown

would be great to merge this as soon as possible 👍

@bragboy

bragboy commented Sep 23, 2020

Copy link
Copy Markdown
Author

For those waiting on this PR to be merged, the better option is to remove this gem altogether and instead use (under group: 'test')

  gem 'webdrivers', '~> 4.0'

@parndt

parndt commented Sep 23, 2020

Copy link
Copy Markdown

For those waiting on this PR to be merged, the better option is to remove this gem altogether and instead use (under group: 'test')

Thanks @bragboy ! I tried that.. I get this:

Selenium::WebDriver::Error::WebDriverError:
  unable to connect to geckodriver 127.0.0.1:4445

Do you think I'm possibly missing something else that you have?

@hunterae

Copy link
Copy Markdown

@bragboy , I used to use the webdrivers gem but kept running into issues with Chrome updates regularly breaking everything. Things have been working a lot smoother since switching over to the firefox Gecko drivers, and this gem is the easiest way to get it working on CI.

@SunnyMagadan

Copy link
Copy Markdown

This PR is hanging for two months. Are there any blockers or reasons to delay the merge? /CC @dmitryreznik

@matiasgarcia

Copy link
Copy Markdown

@dmitryreznik friendly ping to merge this :)

@MichaelCordingley

MichaelCordingley commented Dec 3, 2020

Copy link
Copy Markdown

This PR has been sitting for three months now and I note that the main branch hasn't received a commit in at least two years. The library is under MIT license. I recommend that somebody who's interested in maintaining it fork this, mention it somewhere noticeable here for people to discover, and notify prominent upstream consumers of the fork. It's starting to look like this project is dead and will cause a decent amount of pain before it's eventually replaced or forked.

@dmitryreznik Would love to hear you comment on this.

@0rvar

0rvar commented Dec 10, 2020

Copy link
Copy Markdown

I have forked this gem, incorporated this PR, upgraded further to 0.28, and published geckodriver-bin:

https://github.com/0rvar/geckodriver-bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants