thumbnailer: Simplify pixbuf scaling #107
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of saving the thumbnail into a file and then read it back, read and scale it directly from the surface.
Diego-Ivan
reviewed
Apr 16, 2025
| var pixbuf = new Gdk.Pixbuf.from_file_at_size (save_path, (int) scaled_width, (int) scaled_height); | ||
| var texture = Gdk.Texture.for_pixbuf (pixbuf); | ||
| var pixbuf = Gdk.pixbuf_get_from_surface (surface, 0, 0, width, height); | ||
| var scaled_pixbuf = pixbuf.scale_simple ((int) scaled_width, (int) scaled_height, Gdk.InterpType.BILINEAR); |
Owner
There was a problem hiding this comment.
Unfortunately, GdkPixbuf's scaling provides a lower quality thumbnail. In the DocumentThumbnail widget we use either a Trilinear interpolation or a nearest interpolation. The latter is supported by GdkPixbuf but the former is not.
I also want to remove GdkPixbuf from the codebase in favor of Glycin since it plays better with GdkTextures and would allow us to remove this ugly scaling implementation I made.
Paper-Clip/src/DocumentThumbnail.vala
Lines 73 to 78 in 7777db7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of saving the thumbnail into a file and then read it back, read and scale it directly from the surface.