Inject 'helm.sh/resource-policy: keep' into doppler-operator-system namespace #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emily-curry
approved these changes
Jun 4, 2025
| # Inject 'helm.sh/resource-policy: keep' into doppler-operator-system namespace to prevent it from being destroyed if chart is uninstalled. | ||
| # This will also allow future versions of the chart to remove this resource entirely. | ||
| $(YQ) e 'select(.kind == "Namespace") | .metadata.annotations."helm.sh/resource-policy" = "keep"' dist/recommended.yaml > $(CHART_DIR)/templates/namespace.yaml | ||
| $(YQ) e 'select(.kind != "CustomResourceDefinition" and .kind != "Namespace")' dist/recommended.yaml > $(CHART_DIR)/templates/all.yaml |
There was a problem hiding this comment.
check/question: With the removal of the Namespace from all.yaml, will we need to do anything else for helm users (new and existing) to pick up the new namespace.yaml file?
There was a problem hiding this comment.
Good question! The filenames in our helm chart should not matter. Helm will render all of the templates and send the manifests to Kubernetes (where they'll be updated in-place). In my testing, upgrading to this version simply adds the new annotation.
@seslattery, can you confirm my understanding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DKO Helm chart automatically generates the
doppler-operator-systemnamespace during installation. We'd like to start respecting the Helm installation namespace in v2 of the operator but if we simply drop thedoppler-operator-systemnamespace manifest from our chart, it'll be destroyed from user installations (along with anyDopplerSecretresources and secrets inside).We're adding
helm.sh/resource-policy: keepto allow future versions of the chart to be upgraded or uninstalled without destroying thedoppler-operator-systemnamespace.