Skip to content

Inject 'helm.sh/resource-policy: keep' into doppler-operator-system namespace #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Inject 'helm.sh/resource-policy: keep' into doppler-operator-system namespace #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,10 @@ charts: manifests kustomize helm-tool yq dist
mkdir -p $(CHART_DIR)/crds
mkdir -p $(CHART_DIR)/templates
$(YQ) e 'select(.kind == "CustomResourceDefinition")' dist/recommended.yaml > $(CHART_DIR)/crds/all.yaml
$(YQ) e 'select(.kind != "CustomResourceDefinition")' dist/recommended.yaml > $(CHART_DIR)/templates/all.yaml
# Inject 'helm.sh/resource-policy: keep' into doppler-operator-system namespace to prevent it from being destroyed if chart is uninstalled.
# This will also allow future versions of the chart to remove this resource entirely.
$(YQ) e 'select(.kind == "Namespace") | .metadata.annotations."helm.sh/resource-policy" = "keep"' dist/recommended.yaml > $(CHART_DIR)/templates/namespace.yaml
$(YQ) e 'select(.kind != "CustomResourceDefinition" and .kind != "Namespace")' dist/recommended.yaml > $(CHART_DIR)/templates/all.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check/question: With the removal of the Namespace from all.yaml, will we need to do anything else for helm users (new and existing) to pick up the new namespace.yaml file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! The filenames in our helm chart should not matter. Helm will render all of the templates and send the manifests to Kubernetes (where they'll be updated in-place). In my testing, upgrading to this version simply adds the new annotation.

@seslattery, can you confirm my understanding?

cp hack/helm/Chart.yaml $(CHART_DIR)/
cp hack/helm/NOTES.txt $(CHART_DIR)/templates/
touch $(CHART_DIR)/values.yaml
Expand Down