Rewrite pressure-gradient force in Omega v1 equations#351
Open
xylar wants to merge 2 commits intoE3SM-Project:developfrom
Open
Rewrite pressure-gradient force in Omega v1 equations#351xylar wants to merge 2 commits intoE3SM-Project:developfrom
xylar wants to merge 2 commits intoE3SM-Project:developfrom
Conversation
This was referenced Feb 23, 2026
xylar
force-pushed
the
omega/docs/fix-omega-v1-momentum-derivation
branch
from
9b57ff3 to
912179e
Compare
xylar
commented
Feb 23, 2026
xylar
commented
Feb 23, 2026
Author
|
@sbrus89, could you review when you have time? |
vanroekel
reviewed
Feb 23, 2026
Collaborator
|
@xylar I just pushed a series of changes to address the comments. I also went back and rethought through how to derive the parameterization quantities. I ended up removing discussions of Reynolds' averaging for a projection approach which feels cleaner. Let me know what you think. |
This removes confusing description related to Reynolds' averaging and discusses instead resolved and unresolved through projection operators this removes unecessary dependence on specific averaging. It also adds description as to why the alpha' grad p' term is ignored The description of the vertical viscosity sections is cleaned up
xylar
force-pushed
the
omega/docs/fix-omega-v1-momentum-derivation
branch
from
8f04009 to
34de80f
Compare
Author
|
Thanks @vanroekel, I appreciate your changes here. I think they look good! |
Author
|
@vanroekel, if you could also review my changes when you have time, that would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge makes a significant change to how the pressure-gradient force term is derived in the Omega v1 equations. In the previous version, I had tried too hard to avoid the continuous equations, instead insisting on a finite-volume representation without derivatives at the beginning of the derivation. In particular, we need$\nabla \Phi$ to be included in the body force in our derivation.
The results of these changes were used in the implementation of the horizontal pressure-gradient force (HPGF) that @sbrus89 and I have derived for Omega and will add shortly.
Checklist