Skip to content

draft to start updating to CMIP7 data for CTSM5.4#3083

Merged
ekluzek merged 149 commits intoESCOMP:alpha-ctsm5.4.CMIP7from
wwieder:mksrf_5.4
Apr 23, 2025
Merged

draft to start updating to CMIP7 data for CTSM5.4#3083
ekluzek merged 149 commits intoESCOMP:alpha-ctsm5.4.CMIP7from
wwieder:mksrf_5.4

Conversation

@wwieder
Copy link
Contributor

@wwieder wwieder commented Apr 23, 2025

Description of changes

updating to latest LULCC and urban data for CMIP7

Specific notes

Data processed by @lawrencepj1 and @olyson

Fixes ##2851

purpose here is just to make ne30 and f09 grids to evaluate the new surface datasets before updating gen_mksurfdata_namelist.xml and creating the 'final' CTSM5.4 datasets

@wwieder
Copy link
Contributor Author

wwieder commented Apr 23, 2025

@ekluzek and @olyson can you look to see I updated the xml file correctly? If it looks OK I'll generate the 1 degree surface datasets.

Copy link
Contributor

@olyson olyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. See my comment about line 254

@ekluzek ekluzek changed the base branch from master to alpha-ctsm5.4.CMIP7 April 23, 2025 19:53
@ekluzek ekluzek marked this pull request as ready for review April 23, 2025 22:02
@ekluzek ekluzek self-assigned this Apr 23, 2025
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability priority: Immediate Highest priority, something that was unexpected science Enhancement to or bug impacting science labels Apr 23, 2025
@ekluzek ekluzek added this to the ctsm5.4.0: CMIP7 Datasets milestone Apr 23, 2025
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our starting point for being able to make ctsm5.4 datasets.

@ekluzek ekluzek merged commit a6f1716 into ESCOMP:alpha-ctsm5.4.CMIP7 Apr 23, 2025
2 checks passed
@ekluzek ekluzek deleted the mksrf_5.4 branch April 23, 2025 22:28
@olyson
Copy link
Contributor

olyson commented Apr 24, 2025

I think something went wrong with the PCT_URBAN part of the surface dataset generation for /glade/derecho/scratch/wwieder/mksrf_5.4/surfdata_0.9x1.25_hist_1850_78pfts_c250423.nc. I'm looking into it.

@olyson
Copy link
Contributor

olyson commented Apr 24, 2025

The mksrf_furban_mesh in the namelist needs to be changed from /glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/mappingdata/grids/UNSTRUCTgrid_3x3min_nomask_cdf5_c200129.nc to /glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/mappingdata/grids/UNSTRUCTgrid_0.25x0.25_nomask_cdf5_c200129.nc

The GaoOneill data was at 3x3min, but the CMIP7 data is at 0.25x0.25.

When you regenerate the 1850 dataset can you generate a landuse timeseries as well? I'd like to look at the transient urban before we commit to doing spinup simulations with the 1850 dataset.

@olyson
Copy link
Contributor

olyson commented Apr 24, 2025

The new 1850 surface dataset and landuse timeseries (1850-2023) that you generated (#3089 (review)) look reasonable with respect to urban. I would like to make one change however, that is, eliminate the TBD class prior to 1900. Even though the percentages are very small, that type really shouldn't exist prior to 1900 as the first skyscrapers weren't built until the 1880s. So I will generate a new set of raw urban files and then we can re-create the datasets, perhaps after Peter has a look at the datasets also...?

@wwieder
Copy link
Contributor Author

wwieder commented Apr 25, 2025

Sounds good. Let me know when it's ready

@olyson
Copy link
Contributor

olyson commented Apr 26, 2025

Sounds good. Let me know when it's ready

I've made the change to TBD and generated a new set of raw urban files, looks good. They are in the same location with a date of 250423, e.g.,

/glade/campaign/cgd/tss/people/oleson/Dynamic_Urban_Data/CMIP7/urban_properties_CMIP7_ThreeClass_2023_c250423.nc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new capability or improved behavior of existing capability priority: Immediate Highest priority, something that was unexpected science Enhancement to or bug impacting science

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

6 participants