Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
149 commits
Select commit Hold shift + click to select a range
4575646
make new canopystate_inst variable
adrifoster Feb 5, 2025
0cc6c76
update to use new array
adrifoster Feb 5, 2025
cf52947
update calls
adrifoster Feb 5, 2025
8b02eb7
fix typos
adrifoster Feb 5, 2025
904b184
update names; add endrun
Feb 7, 2025
f0f4c1c
update names
adrifoster Feb 13, 2025
23ad050
Merge branch 'master' into fix_fates_sp
adrifoster Feb 14, 2025
7dc5a09
update
adrifoster Feb 18, 2025
9cb42ec
testing
adrifoster Feb 18, 2025
90a9dc9
fix
Feb 19, 2025
88ab16e
update
Feb 19, 2025
b352cbb
back to original
Feb 19, 2025
49e5437
fix typo
adrifoster Feb 20, 2025
2bd496b
remove unused vars
adrifoster Feb 20, 2025
c4b50d7
Merge branch 'master' into fix_fates_sp
adrifoster Feb 27, 2025
a240f9c
Update conda_env_ctsm_py.txt to use Python 3.11.11.
samsrabin Mar 4, 2025
2b8714c
Try Python 3.13.2 after removing six(_additions).py
samsrabin Mar 4, 2025
e56ee4d
Get Python unit tests working.
samsrabin Mar 4, 2025
30d2682
Reformat with black.
samsrabin Mar 4, 2025
2c3d3a5
Add previous commit to .git-blame-ignore-revs
samsrabin Mar 4, 2025
3c23c96
Resolve useless-option-value pylint errors.
samsrabin Mar 4, 2025
55681ee
Resolve unknown-option-value and unrecognized-option pylint errors.
samsrabin Mar 4, 2025
8d64e0c
Resolve wrong-import-order pylint errors.
samsrabin Mar 4, 2025
d50ed55
Update black in Github workflow.
samsrabin Mar 4, 2025
6c2d503
Resolve unnecessary-dunder-call pylint errors.
samsrabin Mar 4, 2025
9762df9
Generate .pylintrc_3_13_2.
samsrabin Mar 4, 2025
68a5907
Bring over custom things from .pylintrc to .pylintrc_3_13_2.
samsrabin Mar 4, 2025
97fa595
Replace .pylintrc with .pylintrc_3_13_2.
samsrabin Mar 4, 2025
6cbf4fa
Disable too-many-positional-arguments pylint error for existing funct…
samsrabin Mar 4, 2025
b1be486
Resolve implicit-str-concat pylint errors.
samsrabin Mar 4, 2025
bc3bb36
Add timeout (default 30s) to requests.get() call.
samsrabin Mar 4, 2025
348e94e
Resolve (possibly-)used-before-assignment pylint errors.
samsrabin Mar 4, 2025
e6dc462
Remove usage of six.
samsrabin Mar 5, 2025
3d04d6b
Suppress pylint consider-using-dict-items in a poorly-tested function.
samsrabin Mar 5, 2025
9328d8d
Resolve pylint warnings to use {} instead of dict().
samsrabin Mar 5, 2025
3048936
Resolve remaining pylint issues.
samsrabin Mar 5, 2025
add9933
Freeze all versions in conda_env_ctsm_pylib_3_13_2.txt.
samsrabin Mar 5, 2025
ea4c542
Replace conda_env_ctsm_py.txt with conda_env_ctsm_pylib_3_13_2.txt.
samsrabin Mar 5, 2025
550129e
Remove empty requirements.txt.
samsrabin Mar 5, 2025
b8e4f87
py_env_create: Add -n/--name option for custom env name.
samsrabin Mar 12, 2025
a258d28
py_env_create: Ask user how to handle existing env.
samsrabin Mar 12, 2025
dc1ec64
py_env_create: Exit on errors.
samsrabin Mar 12, 2025
391f89d
py_env_create: Rename a variable.
samsrabin Mar 12, 2025
4e5a8e9
py_env_create: Add --quiet to conda remove.
samsrabin Mar 12, 2025
be9c170
py_env_create: Better error handling.
samsrabin Mar 12, 2025
b68ed0a
py_env_create: Refactor to make rename_existing_env.
samsrabin Mar 12, 2025
a0517bf
py_env_create: Improve a message.
samsrabin Mar 12, 2025
1e5eac6
py_env_create: Don't allow running from within a conda env.
samsrabin Mar 12, 2025
eb52ea2
py_env_create: trap and exit on Ctrl-C.
samsrabin Mar 12, 2025
5ec2e49
Many changes for testing py_env_create.
samsrabin Mar 12, 2025
287503b
Move test_sys_py_env_create.py into main test dir.
samsrabin Mar 12, 2025
5fab728
test_sys_py_env_create now uses standard ctsm_pylib.
samsrabin Mar 12, 2025
5493aab
Slight refactor of test_sys_py_env_create.py.
samsrabin Mar 13, 2025
21369a9
py_env_create: Fix default name help msg.
samsrabin Mar 13, 2025
65364b4
test_sys_py_env_create: tearDown() bugfix.
samsrabin Mar 13, 2025
2d2ae3e
py_env_create: Improve an error msg.
samsrabin Mar 13, 2025
2d2f659
py_env_create: Error if both -r and -o given.
samsrabin Mar 13, 2025
b11b346
test_sys_py_env_create: Test more option flag variants.
samsrabin Mar 13, 2025
87b7bd2
py_env_create: Remove untestable user interaction code.
samsrabin Mar 13, 2025
5dedee2
Rename a test.
samsrabin Mar 13, 2025
890b463
Rearrange test_sys_py_env_create.py.
samsrabin Mar 13, 2025
0902ac0
Add previous commit to .git-blame-ignore-revs.
samsrabin Mar 13, 2025
104bbca
py_env_create: Send some more messages to stderr.
samsrabin Mar 13, 2025
9e282ab
Fix a subprocess.run(check=).
samsrabin Mar 13, 2025
4014df7
py_env_create test: Ensure error if env exists and -r name does too.
samsrabin Mar 13, 2025
1d91d78
py_env_create: Test errors in renaming/overwriting active conda env.
samsrabin Mar 13, 2025
c20c2e9
test_sys_py_env_create: Refactor to make _create_empty_env().
samsrabin Mar 13, 2025
5a44edf
Refactor test_sys_py_env_create.py.
samsrabin Mar 13, 2025
45f1f2f
test_sys_py_env_create.py: Refactor to make get_conda_envs().
samsrabin Mar 13, 2025
7f825c0
test_sys_py_env_create.py: Refactor to make does_env_exist().
samsrabin Mar 13, 2025
c96d0f8
test_sys_py_env_create.py: _create_empty_env() now smart about check.
samsrabin Mar 13, 2025
29000c5
Add ctsm_pylib doc to User's Guide.
samsrabin Mar 13, 2025
fbcca84
py_env_create: Remove an unnecessary line breaking portability.
samsrabin Mar 13, 2025
b1d7c06
py_env_create: Fallback to mamba; add -q/--quiet; improve -v/--verbose.
samsrabin Mar 13, 2025
630db49
py_env_create: Messaging improvements.
samsrabin Mar 13, 2025
7634832
Add note about coordinating black version.
samsrabin Mar 13, 2025
7ce57dc
py_env_create: Remove refs to mamba from usage().
samsrabin Mar 13, 2025
1972cef
Reformat with black.
samsrabin Mar 13, 2025
8dc32f5
Add previous commit to .git-blame-ignore-revs.
samsrabin Mar 13, 2025
df30eed
Calculate gs_mol_sun (GSSUN) and gs_mol_sha (GSSHA) at night in
olyson Mar 18, 2025
67a7f1e
Calculate gs_mol_sun (GSSUN) and gs_mol_sha (GSSHA) at night in Photo…
olyson Mar 18, 2025
7d36d37
Add comments
olyson Mar 18, 2025
12a77c7
add fates testmod history output to LUH2 testmod
glemieux Mar 18, 2025
798fdee
Comment cleanup
olyson Mar 19, 2025
32c103f
Add some comments about exiting py_env_create.
samsrabin Mar 20, 2025
2d8464f
py_env_create: remove SCRIPT_DIR bit.
samsrabin Mar 20, 2025
3fcc585
py_env_create: Explain the conda/mamba test env thing at the top.
samsrabin Mar 20, 2025
d047269
Add a comment explaining empty.txt.
samsrabin Mar 20, 2025
b24aba5
py_env_create: Better err msg if neither conda nor mamba work.
samsrabin Mar 20, 2025
1c1ae01
py_env_create: conda/mamba unavailable error now goes to stderr.
samsrabin Mar 20, 2025
637511d
Fix too-many-positional-arguments for some functions by making args k…
samsrabin Mar 20, 2025
29ec907
Explain ignoring too-many-positional-arguments in python/ctsm/crop_ca…
samsrabin Mar 20, 2025
0e14caf
Resolve more too-many-positional-arguments complaints.
samsrabin Mar 20, 2025
5fd8421
Resolve even more too-many-positional-arguments complaints.
samsrabin Mar 20, 2025
854ddd8
Resolve remaining too-many-positional-arguments complaints.
samsrabin Mar 20, 2025
a9081cd
py_env_create: --help now says -r and -o are incompatible.
samsrabin Mar 20, 2025
0b996ac
testlist_clm.xml: Fix name of clm_pymods suite in a comment.
samsrabin Mar 20, 2025
c6d9948
Add README.updating_ctsm_pylib.md.
samsrabin Mar 20, 2025
b5e1080
Merge tag 'ctsm5.3.035' into merge-master-20250327
samsrabin Mar 29, 2025
49e224a
Merge tag 'ctsm5.3.035' into fates-test-add-luh-output
glemieux Mar 31, 2025
01a0fb7
Merge pull request #3040 from samsrabin/merge-master-20250327
samsrabin Mar 31, 2025
09c7f31
update crop expected fail to RUN
glemieux Mar 31, 2025
9956c74
Add ctsm5.3.036 change log
glemieux Apr 1, 2025
eacff10
Merge pull request #3022 from glemieux/fates-test-add-luh-output
samsrabin Apr 1, 2025
5ac991b
Merge tag 'ctsm5.3.036' into gssunsha
ekluzek Apr 1, 2025
6bb60b1
Add pytest and coverage.
samsrabin Apr 1, 2025
d27833b
Fix 'Exit on Ctrl-C'.
samsrabin Apr 1, 2025
6c9ba70
Fix SCRIPT_DIR vs. dir.
samsrabin Apr 1, 2025
7cf82d7
py_env_create: Add --old option to install 3.7.9 ctsm_pylib.
samsrabin Apr 1, 2025
f5aa204
py_env_create: Add -d/--dry-run option.
samsrabin Apr 1, 2025
9040dc3
py_env_create: Add -m/--mamba option to skip automatic determination.
samsrabin Apr 1, 2025
f5939b0
py_env_create: Always use conda to rename.
samsrabin Apr 2, 2025
276dedb
Add tests for py_env_create dry run, old, and mamba.
samsrabin Apr 1, 2025
fdcaf3f
Update change files
ekluzek Apr 2, 2025
aaf4769
Update date
ekluzek Apr 3, 2025
21396c3
Merge pull request #3021 from olyson/gssunsha
ekluzek Apr 3, 2025
d4ada44
Merge branch 'b4b-dev' into ctsm_pylib_3.13.2
samsrabin Apr 6, 2025
0da11ae
User's Guide: Link to using-ctsm-pylib page in subset-data page.
samsrabin Apr 6, 2025
b75d84d
Merge branch 'master-upstream' into ctsm_pylib_3.13.2
samsrabin Apr 6, 2025
74adfa5
py_env_create: Improve help text for --rename-existing.
samsrabin Apr 7, 2025
e07c199
Add subroutine for filling output arrays.
samsrabin Aug 30, 2024
cd8072d
Put back commented-out organic_o option 2.
samsrabin Aug 30, 2024
1f5772e
Fixes to organic_o option 2.
samsrabin Sep 4, 2024
a0c3c6e
mksoiltex: Rename is_neg_4 to is_sand_dune.
samsrabin Apr 1, 2025
6f008d1
Remove organic_o option 2.
samsrabin Apr 1, 2025
415382d
Check sand for negative values.
samsrabin Apr 1, 2025
fe2288b
Check for negative values in organic_o.
samsrabin Apr 1, 2025
64bc086
Improve mksurfdata_esmf .gitignore.
samsrabin Apr 4, 2025
05db3c3
gen_mksurfdata_jobscript: Use ACCOUNT as default, falling back to P93…
samsrabin Apr 4, 2025
cddd069
mksoiltex: Remove remaining unused 'option 2' code.
samsrabin Apr 7, 2025
4dc79e8
Improve 'Calculate organic' comment.
samsrabin Apr 7, 2025
501a596
mksoiltex: Add description of mksoiltex_i_to_o().
samsrabin Apr 7, 2025
839ef6b
mksurfdata_esmf: Fix longitude for 1x1_brazil.
samsrabin Apr 8, 2025
d850e16
Merge pull request #2737 from samsrabin/refactor-mksoiltex
samsrabin Apr 9, 2025
45bca5e
Merge commit '21396c3' (ctsm5.3.037) into merge-b4bdev-20250410
samsrabin Apr 10, 2025
aaa6b2f
Update ChangeLog and ChangeSum.
samsrabin Apr 10, 2025
38e25b8
Merge pull request #3059 from samsrabin/merge-b4bdev-20250410
samsrabin Apr 10, 2025
7666b9d
Merge branch 'master' into fix_fates_sp
Apr 11, 2025
937612b
fix variable names
Apr 11, 2025
69daf59
fix use_fates
adrifoster Apr 14, 2025
cd7b505
changelog
adrifoster Apr 15, 2025
f85d6a8
Merge pull request #2952 from adrifoster/fix_fates_sp
adrifoster Apr 15, 2025
2be363b
py_env_create: Include new env name in help for --rename-existing.
samsrabin Apr 15, 2025
34ba0d6
Merge tag 'ctsm5.3.039' into ctsm_pylib_3.13.2
samsrabin Apr 15, 2025
b4d07e0
Update ChangeLog and ChangeSum.
samsrabin Apr 15, 2025
c2a8c6c
Merge pull request #2982 from samsrabin/ctsm_pylib_3.13.2
samsrabin Apr 15, 2025
e8315ff
draft to start updating to CMIP7 data for CTSM5.4
wwieder Apr 23, 2025
1901125
remove urban comment
wwieder Apr 23, 2025
6eb3d8b
change to active account key
wwieder Apr 23, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .git-blame-ignore-revs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Ran python directory through black python formatter
# Reformat with black
d89c86e7776bbf7451860b60038b4725fe7a0560
b429b63824e09f82e95d2982f14311cbbd8e4a37
d229b5c6689efc4c2a6cef077515c4ccd5c18ff6
Expand Down Expand Up @@ -29,7 +29,6 @@ e096358c832ab292ddfd22dd5878826c7c788968
475831f0fb0e31e97f630eac4e078c886558b61c
fd5f177131d63d39e79a13918390bdfb642d781e
a51816e0de380300b69db9fc3e2c7fa83b267b64
# Ran SystemTests and python/ctsm through black python formatter
5364ad66eaceb55dde2d3d598fe4ce37ac83a93c
8056ae649c1b37f5e10aaaac79005d6e3a8b2380
0bc3f00115d86d026a977918661c93779b3b19f9
Expand Down Expand Up @@ -59,4 +58,7 @@ bd535c710db78420b8e8b9d71d88d8339e899c59
cf433215b58ba8776ec5edfb0b0d80c0836ed3a0
16d57ff37859b34dab005693e3085d64e2bcd95a
e8fc526e0d7818d45f171488c78392c4ff63902a
30d2682a0893f5620bfe37ca6e2614fa60c99f51
890b4633c5477dc074f79c69c40d650196337591
1972cef6bba0d97169b30a53f540d56bcbd97281
cdf40d265cc82775607a1bf25f5f527bacc97405
8 changes: 4 additions & 4 deletions .github/workflows/black.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@ jobs:
options: "--check --config python/pyproject.toml"
src: "./python"
# Version should be coordinated with the ctsm_pylib conda environment under the python directory
version: "22.3.0"
version: "25.1.0"
# Actions identical to above for each directory and source file we need to check (arrays aren't allowed for src: field)
- uses: psf/black@stable
with:
options: "--check --config python/pyproject.toml"
src: "./cime_config/SystemTests"
version: "22.3.0"
version: "25.1.0"
- uses: psf/black@stable
with:
options: "--check --config python/pyproject.toml"
src: "./cime_config/buildlib"
version: "22.3.0"
version: "25.1.0"
- uses: psf/black@stable
with:
options: "--check --config python/pyproject.toml"
src: "./cime_config/buildnml"
version: "22.3.0"
version: "25.1.0"
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,11 @@ ctsm.input_data_list.previous
/tools/mksurfdata_esmf/mksurfdata_in
/tools/mksurfdata_esmf/surfdata_*.nc
/tools/mksurfdata_esmf/landuse.timeseries_*.nc
/tools/mksurfdata_esmf/mksurfdata_jobscript_multi.sh
/tools/mksurfdata_esmf/mksurfdata_jobscript_single.sh
/tools/mksurfdata_esmf/pio_iotype.txt
/tools/mksurfdata_esmf/*.sh
/tools/mksurfdata_esmf/tool_bld
/tools/mksurfdata_esmf/pio_iotype.txt
/tools/mksurfdata_esmf/mpibind*.log

# mksurfdata unit tests
unit_test_build
Expand Down
1 change: 1 addition & 0 deletions cime_config/SystemTests/mksurfdataesmf.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
I added -C to the `git describe` in gen_mksurfdata_namelist for this
system test to work.
"""

import os
import sys
import subprocess
Expand Down
1 change: 1 addition & 0 deletions cime_config/SystemTests/pvt.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
2) run a transient landuse case with use_fates_lupft
- start from the restart file generated in (1)
"""

from CIME.XML.standard_module_setup import *
from CIME.SystemTests.system_tests_common import SystemTestsCommon
from CIME.SystemTests.test_utils.user_nl_utils import append_to_user_nl_files
Expand Down
1 change: 1 addition & 0 deletions cime_config/SystemTests/ssp.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- start from the restart files generated in (1)
- turn MOSART off
"""

from CIME.XML.standard_module_setup import *
from CIME.SystemTests.system_tests_common import SystemTestsCommon
import shutil, glob, os
Expand Down
1 change: 1 addition & 0 deletions cime_config/SystemTests/sspmatrixcn.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
Step 3: Run a slow-mode spinup
Step 4: matrix Spinup off
"""

import shutil, glob, os, sys
from datetime import datetime

Expand Down
1 change: 1 addition & 0 deletions cime_config/buildlib
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ from CIME.utils import run_cmd, expect

logger = logging.getLogger(__name__)


###############################################################################
def _write_ctsm_mk(gmake, gmake_opts, makefile, exeroot, libroot):
"""Writes a ctsm.mk file in exeroot.
Expand Down
2 changes: 1 addition & 1 deletion cime_config/testdefs/ExpectedTestFails.xml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
</test>

<test name="SMS_D.f10_f10_mg37.I2000Clm60BgcCrop.derecho_nvhpc.clm-crop">
<phase name="SHAREDLIB_BUILD">
<phase name="RUN">
<status>FAIL</status>
<issue>#1733</issue>
</phase>
Expand Down
2 changes: 1 addition & 1 deletion cime_config/testdefs/testlist_clm.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0"?>
<!--
CTSM test list. Test suites included:
ctsm_pymods: System tests for the python codes that also run CTSM cases (subset of aux_clm tests)
clm_pymods: System tests for the python code that also run CTSM cases (subset of aux_clm tests)
clm_short: The short CLM test for basic testing of a few configurations
aux_clm: Main workhorse test list to be run on main machines before most tags are made
fates: The FATES testlist, run when FATES is updated
Expand Down
25 changes: 24 additions & 1 deletion cime_config/testdefs/testmods_dirs/clm/FatesColdLUH2/user_nl_clm
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,28 @@ use_fates_nocomp = .true.
use_fates_fixed_biogeog = .true.
use_fates_sp = .false.
use_fates_potentialveg = .false.
hist_fincl1 = 'FATES_PATCHAREA_LU', 'FATES_DISTURBANCE_RATE_MATRIX_LULU',
hist_fincl1 = 'FATES_NCOHORTS', 'FATES_TRIMMING', 'FATES_AREA_PLANTS',
'FATES_AREA_TREES', 'FATES_COLD_STATUS', 'FATES_GDD',
'FATES_NCHILLDAYS', 'FATES_NCOLDDAYS', 'FATES_DAYSINCE_COLDLEAFOFF','FATES_DAYSINCE_COLDLEAFON',
'FATES_CANOPY_SPREAD', 'FATES_NESTEROV_INDEX', 'FATES_IGNITIONS', 'FATES_FDI',
'FATES_ROS','FATES_EFFECT_WSPEED', 'FATES_FUELCONSUMED', 'FATES_FIRE_INTENSITY',
'FATES_FIRE_INTENSITY_BURNFRAC', 'FATES_BURNFRAC', 'FATES_FUEL_MEF',
'FATES_FUEL_BULKD', 'FATES_FUEL_EFF_MOIST', 'FATES_FUEL_SAV',
'FATES_FUEL_AMOUNT', 'FATES_LITTER_IN', 'FATES_LITTER_OUT',
'FATES_SEED_BANK', 'FATES_SEEDS_IN', 'FATES_STOREC', 'FATES_VEGC',
'FATES_SAPWOODC', 'FATES_LEAFC', 'FATES_FROOTC', 'FATES_REPROC',
'FATES_STRUCTC', 'FATES_NONSTRUCTC', 'FATES_VEGC_ABOVEGROUND',
'FATES_CANOPY_VEGC', 'FATES_USTORY_VEGC', 'FATES_PRIMARY_PATCHFUSION_ERR',
'FATES_HARVEST_WOODPROD_C_FLUX', 'FATES_DISTURBANCE_RATE_FIRE',
'FATES_DISTURBANCE_RATE_LOGGING', 'FATES_DISTURBANCE_RATE_TREEFALL',
'FATES_STOMATAL_COND', 'FATES_LBLAYER_COND', 'FATES_NPP', 'FATES_GPP',
'FATES_AUTORESP', 'FATES_GROWTH_RESP', 'FATES_MAINT_RESP', 'FATES_GPP_CANOPY',
'FATES_AUTORESP_CANOPY', 'FATES_GPP_USTORY', 'FATES_AUTORESP_USTORY',
'FATES_DEMOTION_CARBONFLUX', 'FATES_PROMOTION_CARBONFLUX',
'FATES_MORTALITY_CFLUX_CANOPY', 'FATES_MORTALITY_CFLUX_USTORY',
'FATES_NEP', 'FATES_HET_RESP', 'FATES_FIRE_CLOSS', 'FATES_FIRE_FLUX_EL',
'FATES_CBALANCE_ERROR', 'FATES_ERROR_EL', 'FATES_LEAF_ALLOC',
'FATES_SEED_ALLOC', 'FATES_STEM_ALLOC', 'FATES_FROOT_ALLOC',
'FATES_CROOT_ALLOC', 'FATES_STORE_ALLOC',
'FATES_PATCHAREA_LU', 'FATES_DISTURBANCE_RATE_MATRIX_LULU',
'FATES_TRANSITION_MATRIX_LULU'
Loading