Mac monterey build fixes #5172
Mac monterey build fixes #5172
Conversation
plugins/offers_invreq_hook.c
Outdated
| @@ -447,7 +447,7 @@ static bool check_payer_sig(struct command *cmd, | |||
|
|
|||
| return secp256k1_schnorrsig_verify(secp256k1_ctx, | |||
| sig->u8, | |||
| sighash.u.u8, sizeof(sighash.u.u8), &payer_key->pubkey) == 1; | |||
| sighash.u.u8, sizeof(sighash), &payer_key->pubkey) == 1; | |||
There was a problem hiding this comment.
I think it was more correct before these changes? Thought this shouldn't change anything on any platform we support...
There was a problem hiding this comment.
@rustyrussell that change was suggested ElementsProject/libwally-core#321 (comment) am happy to revert it out if incorrect
What is the best way for me to test?
I'm just playing around on testnet with lnurl, and a lightning addresses implementation so am not running anything mission critical, happy to be a guinea pig
|
I have tried compiling both versions, and I think there is a problem, been trying to test with the following and it seems like something is broken: lightning-cli signmessage test { lightning-cli checkmessage test [zbase] { |
mdance
force-pushed
the
mac-monterey-build-fixes
branch
from
0f1889b to
d9c2290
Compare
|
Ignore my last comment, I have tested the same command against a arch linux master build and its returning the same thing, I thought the verified: false might have meant the signature verification wasn't working |
|
OK, I stole this into #5180 which now is rebased on the libwally release (yay!). |
I have been working in the comments with ElementsProject/libwally-core#321 to try and compile lightning on Darwin 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:45:05 PDT 2022; root:xnu-8020.101.4~15/RELEASE_X86_64 x86_64
I was able to get it to compile, I am not a c programmer so am not expecting this to make it in, but hopefully it helps someone