Changed external/libwally-core to 0.8.5 release #5180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined with the following commit which is required to update against changed libsecp256k1 APIs: Updated deprecated function calls
vincenzopalazzo
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Looks like the CI fails about a mem leak in one case, and in the other case fails regarding the "deamon died".
But the code change looks unrelated (from reading the stack trace), so for me looks good.
ACK 6f3a216
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
changed the title
|
Closes: #5172 |
|
Ack e7cb4f6 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined with the following commit which is required to
update against changed libsecp256k1 APIs:
Updated deprecated function calls
This is #5172 squished into a single commit (so it doesn't break bisect!) and removing the extraneous commit.
Changelog-None