[No QA] Docs updates for E/A#98056 global More option on every Rules tab - #98480
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#98056 global More option on every Rules tab#98480MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
… import Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
54 tasks
Contributor
Author
|
I looked into the checks — there's nothing to fix in code here. The only failing check is Check independent approval, and it's not a code/test failure. It's a required-reviewer gate that stays red until an independent reviewer approves the PR (the PR author's own approval doesn't satisfy it). Everything else has passed; What's needed: an independent reviewer needs to review and approve this PR — I can't clear that gate by pushing a commit. Full check status
|
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://1704fe2d.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs updates for #98056
Expensify/App#98056 makes the More option (which contains Import merchant rules) global across every tab on the revamped Rules page — previously it only appeared on the Expense defaults tab. It also returns you to the Expense defaults tab after a spreadsheet import completes.
This updates Import Merchant Rules using a spreadsheet to match:
Verification notes
Expensify/App#98056(common.more,workspace.rules.merchantRules.importRulesTitle, and theCONST.TAB.RULES.EXPENSE_DEFAULTSlanding behavior).rulesRevampbeta and the automated test session lost authentication during this run. Please confirm the wording against the live app.@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.