Skip to content

[No QA] Docs updates for E/A#98056 global More option on every Rules tab - #98480

Draft
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-98056-rules-more-option
Draft

[No QA] Docs updates for E/A#98056 global More option on every Rules tab#98480
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-98056-rules-more-option

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Docs updates for #98056

Expensify/App#98056 makes the More option (which contains Import merchant rules) global across every tab on the revamped Rules page — previously it only appeared on the Expense defaults tab. It also returns you to the Expense defaults tab after a spreadsheet import completes.

This updates Import Merchant Rules using a spreadsheet to match:

  • Removed the step telling admins to select the Expense defaults tab before clicking More, since More is now available on any tab. Renumbered the remaining steps.
  • Added a note that after import you're returned to the Expense defaults tab, where the imported rules appear.

Verification notes

  • All UI labels (Rules, More, Import merchant rules, Expense defaults) were verified against the source in Expensify/App#98056 (common.more, workspace.rules.merchantRules.importRulesTitle, and the CONST.TAB.RULES.EXPENSE_DEFAULTS landing behavior).
  • Live UI verification could not be completed: the feature is behind the rulesRevamp beta and the automated test session lost authentication during this run. Please confirm the wording against the live app.

@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

… import

Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 12, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I looked into the checks — there's nothing to fix in code here.

The only failing check is Check independent approval, and it's not a code/test failure. It's a required-reviewer gate that stays red until an independent reviewer approves the PR (the PR author's own approval doesn't satisfy it). Everything else has passed; build is still running.

What's needed: an independent reviewer needs to review and approve this PR — I can't clear that gate by pushing a commit.

Full check status
  • check, dryRun, spellcheck, validate, verify, verifySignedCommits, CLA
  • build — pending
  • Check independent approval — waiting on an independent reviewer's approval (not fixable via code)

@github-actions github-actions Bot changed the title Docs updates for E/A#98056 global More option on every Rules tab [No QA] Docs updates for E/A#98056 global More option on every Rules tab Aug 12, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://1704fe2d.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants