Merged
Conversation
This reverts commit 5c89532.
Member
Nice! That will likely be retired once we close #321, though. |
khvn26
previously approved these changes
Sep 15, 2025
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
Please don't release before we close https://github.com/Flagsmith/github-webhook-handler/issues/10, or before I confirm the Github webhook handler is otherwise running.
Contributor
Author
|
Yes @khvn26 , just wanted to have it ready 👍 |
matthewelwell
changed the title
talissoncosta
previously approved these changes
Oct 23, 2025
talissoncosta
previously approved these changes
Dec 10, 2025
khvn26
reviewed
Dec 10, 2025
khvn26
reviewed
Dec 10, 2025
talissoncosta
force-pushed
the
feat/re-add-sdk-version-headers
branch
from
5c2f1cc to
ccf87e4
Compare
khvn26
requested changes
Dec 10, 2025
talissoncosta
force-pushed
the
feat/re-add-sdk-version-headers
branch
from
ccf87e4 to
d7396db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We reverted the sdk-version header changes due to CORS errors in #342.
This PR re-integrates the headers while releasing a major version.
Additionally added a pre-commit hook to write version without having to build.
Contributes to #333