fix(proxybase): migrate to GHCR peer-cli image + Access Token credentials#96
Merged
Conversation
…ials Mirror of the web catalog fix (CashPilot #103). ProxyBase retired its Docker Hub image and old GHCR org, changed the credential contract, and moved to proxybase.org. - image: proxybase/proxybase -> ghcr.io/proxybaseorg/peer-cli, digest-pinned (multi-arch amd64/arm64/armv7 -- fixes arm64 / Raspberry Pi) - env: USER_ID/DEVICE_NAME -> ID/NAME (verified against the image --help; the new client ignores the old vars and exits with 'Missing ID and NAME') - credential relabelled 'Access Token' and masked (secret: true) - domain proxybase.io -> proxybase.org across website + dashboard link - requirements: datacenter/VPS IPs now accepted (residential still earns most) - add regression test pinning the image + exact ID/NAME env contract - bump productVersion 0.9.0 -> 0.10.1 (was drifted); move the released fleet per-worker-keys entry under [0.10.0] and add [0.10.1] to the changelog
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
📝 WalkthroughWalkthroughChangesProxyBase migration and release
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…test guards Panel-review fixes on top of the migration: - README: ProxyBase VPS IP cell now matches vps_ip: true - package.json / frontend package.json+lock: align 0.9.0 -> 0.10.1 (were drifted alongside wails.json) - tests: guard the referral signup URL, Secret on ID, Residential/VPS flags, and linux/arm64 presence; drop the assertion subsumed by the digest-pin check - docs: BRANCH-2-RUNTIME catalog-corrections note marked done + correct org (proxybaseorg; the proxybase-org-company org no longer exists) - yaml: tighten NAME description (parity with web)
Owner
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
This was referenced Jul 17, 2026
GeiserX
added a commit
that referenced
this pull request
Jul 18, 2026
…ge, real hostname (CashPilot-Desktop-ada) (#99) Four pre-existing latents from the PR #96 review: 1. DeployService persisted credentials BEFORE validation, so a rejected deploy left invalid/blank creds lingering (and lighting the 'Configured' badge for a service that could never start). Validate via the new Manager.ValidateCredentials first; persist only if it passes. 2. buildEnv copied every stored-cred key into the container env unfiltered. Restrict to catalog-declared keys so an orphaned pre-migration key can't leak into a container. (The native twin keeps its documented passthrough.) 3. The 'Configured' badge was len(creds)>0, so an orphaned old-key blob read as configured though a deploy would fail. Key it off the current required fields via Manager.RequiredCredentialsMet. 4. An unedited deploy form resubmitted the raw 'cashpilot-{hostname}' default as an override, which buildEnv only substituted on defaults (and to the literal 'desktop') — producing a device literally named cashpilot-{hostname}. Expand {hostname} to the real host on defaults AND overrides (both runtimes), and surface AppState.hostname so the form renders the real value. Tests: buildEnv filter+hostname, ValidateCredentials/RequiredCredentialsMet, DeployService validate-before-persist. go test -race + vet + gofmt clean, tsc clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the web catalog fix (CashPilot #103) into the desktop catalog. Verified against primary sources: pulled the current image and ran its
--help, and fetched the live site.Root cause
The catalog shipped the retired ProxyBase Docker Hub image (
proxybase/proxybase) withUSER_ID/DEVICE_NAMEenv vars and.ioURLs. ProxyBase moved toghcr.io/proxybaseorg/peer-clionproxybase.orgwith a different env contract, so existing deployments silently stop earning.Changes
services/bandwidth/proxybase.ymlghcr.io/proxybaseorg/peer-cli@sha256:b78dda39…(digest-pinned, multi-arch amd64/arm64/armv7); envUSER_ID/DEVICE_NAME→ID/NAME; credential relabelled Access Token +secret: true;proxybase.io→proxybase.org;residential_ip: false+vps_ip: trueinternal/catalog/proxybase_test.goID/NAMEcontractwails.jsonproductVersion0.9.0 → 0.10.1 (was drifted behind the v0.10.0 release)CHANGELOG.md[0.10.1]; move the already-released fleet per-worker-keys entry from[Unreleased]under[0.10.0]Verified
--help:ProxyBase-Peer [<ID> [<NAME>]], 'set env var ID' / 'set env var NAME'.gofmtclean,go build ./...,go vet ./...,go test ./...all pass (image-pin gate + new contract test included).Release
Tag-driven: after merge, push
v0.10.1to build/publish all three platforms.Backward compatibility
Breaking for existing ProxyBase deployments — the new client won't read the old
USER_ID/DEVICE_NAME. Re-deploy ProxyBase and paste the Access Token.Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores