Display disconnected icon before closing by rom1v · Pull Request #6662 · Genymobile/scrcpy

rom1v · 2026-02-09T17:56:20Z

When the connection to the device is lost while mirroring, the window closed immediately, suggesting scrcpy had crashed.

To make it clear that a disconnection occurred, display a disconnected icon for 2 seconds before closing the window.

The icon replaces the screen content immediately:

On purpose, the last frame is immediately removed. For example, during a presentation, the device might inadvertently show some private content on screen, the user should be able to immediately disconnects the USB cable to remove the content.

I intentionally did not add an option to configure the timeout delay (it's hardcoded to 2 seconds), there are already a lot of options…

The implementation is a bit "ad hoc", but hey it works.

I replaced SCRCPY_ICON_PATH (which defined the unique scrcpy icon) with SCRCPY_ICON_DIR now that there are several icons.

I get the (temporary) disconnected icon from a free icons website (I can't remember where).

@varlesh As the author of the main icon (#1987 (comment)), may I ask you to create an icon for this use case?

This is an "Android disconnection"

in normal mode, it's the adb socket (either over USB or wifi)
in OTG mode, it's the AOA connection (over USB)

so this is not specifically for USB or Wifi (and even less wall socket). If it needs to represent something physical, USB is probably fine though.

rom1v · 2026-02-23T23:29:16Z

I fixed some issues and updated the icon.

The new icon is derived from this one.

I think it makes it clear that the communication with the device is lost:

anotheruserofgithub

Hi, first I noticed a few possible issues.

app/src/screen.c

app/src/disconnect.c

anotheruserofgithub

Then some possible (debatable) improvements.

app/src/disconnect.c

app/src/util/tick.h

anotheruserofgithub

One last suggested improvement from my side.

app/src/screen.c

rom1v · 2026-02-25T22:10:54Z

When the disconnected icon is shown, we should still handle events (to leave fullscreen mode for example).

I will need to rework that before merging.

This makes the icon name consistent everywhere. PR #6662 <#6662>

Add a utility function to create a full path from a directory and a filename. PR #6662 <#6662>

SCRCPY_ICON_PATH defined the path of the scrcpy app icon. SCRCPY_ICON_DIR defines the directory where scrcpy icons reside. This change prepares for the addition of other icons. PR #6662 <#6662>

Replace scrcpy_icon_load(), which loaded the unique scrcpy app icon, with sc_icon_load(filename), which can load any icon from the icons directory. PR #6662 <#6662>

PR #6662 <#6662>

Use SDL_PeepEvents() to consume only SC_EVENT_RUN_ON_MAIN_THREAD events. Other events are not dropped and can still be processed later. PR #6662 <#6662>

Previously, when the connection to the device was lost while mirroring, the window closed immediately, suggesting scrcpy had crashed. To make it clear that a disconnection occurred, display a disconnected icon for 2 seconds before closing the window. PR #6662 <#6662>

rom1v · 2026-03-15T13:40:28Z

I will need to rework that before merging.

Done. Ready to be merged.

(Please review and test if you can)

anotheruserofgithub

Small details of style (just to nitpick).

app/src/events.h

app/src/events.c

app/src/screen.c

anotheruserofgithub · 2026-03-15T23:09:24Z

I still couldn't test for real, I'd need to buy a new phone… one day.

PR #6662 <#6662>

Use SDL_PeepEvents() to consume only SC_EVENT_RUN_ON_MAIN_THREAD events. Other events are not dropped and can still be processed later. PR #6662 <#6662>

Previously, when the connection to the device was lost while mirroring, the window closed immediately, suggesting scrcpy had crashed. To make it clear that a disconnection occurred, display a disconnected icon for 2 seconds before closing the window. PR #6662 <#6662>

rom1v mentioned this pull request Feb 10, 2026

Keep Windows terminal open on error by default #6667

Merged

rom1v force-pushed the disconnected branch from cfa06c8 to 634755b Compare February 23, 2026 23:29

anotheruserofgithub reviewed Feb 24, 2026

View reviewed changes

app/src/screen.c Show resolved Hide resolved

app/src/disconnect.c Outdated Show resolved Hide resolved

app/src/disconnect.c Outdated Show resolved Hide resolved

app/src/disconnect.c Outdated Show resolved Hide resolved

anotheruserofgithub reviewed Feb 24, 2026

View reviewed changes

app/src/disconnect.c Show resolved Hide resolved

app/src/util/tick.h Show resolved Hide resolved

anotheruserofgithub reviewed Feb 24, 2026

View reviewed changes

app/src/screen.c Outdated Show resolved Hide resolved

rom1v force-pushed the disconnected branch from 634755b to 8eb87ba Compare February 25, 2026 22:10

rom1v changed the title ~~Display disconnected icon before closing~~ [Draft] Display disconnected icon before closing Feb 25, 2026

rom1v added 5 commits March 11, 2026 15:40

Rename icon.png to scrcpy.png

c4aefde

This makes the icon name consistent everywhere. PR #6662 <#6662>

Extract function to build file paths

8f51e23

Add a utility function to create a full path from a directory and a filename. PR #6662 <#6662>

Replace SCRCPY_ICON_PATH with SCRCPY_ICON_DIR

7f5fd43

SCRCPY_ICON_PATH defined the path of the scrcpy app icon. SCRCPY_ICON_DIR defines the directory where scrcpy icons reside. This change prepares for the addition of other icons. PR #6662 <#6662>

Add filename parameter to icon loading

2145f6d

Replace scrcpy_icon_load(), which loaded the unique scrcpy app icon, with sc_icon_load(filename), which can load any icon from the icons directory. PR #6662 <#6662>

Add function to delete current texture

28ba091

PR #6662 <#6662>

rom1v added a commit that referenced this pull request Mar 15, 2026

Add utility to push an SDL event with data

9a50c02

PR #6662 <#6662>

rom1v added a commit that referenced this pull request Mar 15, 2026

Only reject RUN_ON_MAIN_THREAD events on quit

a124a87

Use SDL_PeepEvents() to consume only SC_EVENT_RUN_ON_MAIN_THREAD events. Other events are not dropped and can still be processed later. PR #6662 <#6662>

rom1v force-pushed the disconnected branch from 8eb87ba to 0589acf Compare March 15, 2026 13:39

rom1v changed the title ~~[Draft] Display disconnected icon before closing~~ Display disconnected icon before closing Mar 15, 2026

anotheruserofgithub reviewed Mar 15, 2026

View reviewed changes

app/src/events.h Outdated Show resolved Hide resolved

app/src/events.c Outdated Show resolved Hide resolved

app/src/screen.c Show resolved Hide resolved

app/src/screen.c Outdated Show resolved Hide resolved

app/src/screen.c Outdated Show resolved Hide resolved

rom1v added 3 commits March 16, 2026 10:52

Add utility to push an SDL event with data

02949e7

PR #6662 <#6662>

Only reject RUN_ON_MAIN_THREAD events on quit

1da65bb

Use SDL_PeepEvents() to consume only SC_EVENT_RUN_ON_MAIN_THREAD events. Other events are not dropped and can still be processed later. PR #6662 <#6662>

rom1v force-pushed the disconnected branch from 0589acf to 4c84937 Compare March 16, 2026 10:00

Uh oh!

Conversation

rom1v commented Feb 9, 2026

Uh oh!

rom1v commented Feb 23, 2026

Uh oh!

anotheruserofgithub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anotheruserofgithub left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

anotheruserofgithub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rom1v commented Feb 25, 2026

Uh oh!

rom1v commented Mar 15, 2026

Uh oh!

anotheruserofgithub left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anotheruserofgithub commented Mar 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anotheruserofgithub left a comment •

edited

Loading