105 kaavakohteen luominen ilman templaattia, yleisiä muutoksia kaavakohteen luomiseen ja kaavakohdekirjastoihin #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some refactoring was done for related functionalities
- deleted feature_template_library: some functions moved to PlanManager, some to NewFeatureDock - deleted template_library_config: FeatureTemplateLibrary renamed and moved to models.py - renamed template_dock -> new_feature_dock - changed PlanFeatureForm to be initialized from a PlanFeature, following the logic of other form and widget initialization. similarly, FeatureTemplateLibrary now consists of PlanFeatures - WIP: regulation group initialization from plan feature template config, continue designing the new dock
…efactoring - fix PlanDigitizeMapTool to reinitialize itself after layer changes - implement similar config file fetching for regulation group libraries as for feature templates - reorganize library files in resources folder - deactivate selections in NewFeatureDock when PlanFeatureDigitizeMapTool finishes/deactivates
LKajan
approved these changes
Jan 14, 2025
| self.initialize_feature_digitize_map_tool() | ||
|
|
||
| def initialize_feature_digitize_map_tool(self, layer: QgsVectorLayer | None = None): | ||
| # Get matcing capture mode for given layer |
There was a problem hiding this comment.
Tarviiko näitä. Käsittääkseni QgsMapToolDigitizeFeature.setLayer() hoitaa tän automaattisesti.
There was a problem hiding this comment.
Taitaa tarvita, ainakin siltä vaikutti. Tätä voi kyllä testata vielä jossain kohtaa uudestaan
| @@ -102,6 +184,24 @@ def _plan_geom_digitized(self, feature: QgsFeature): | |||
|
|
|||
| iface.mapCanvas().setMapTool(self.previous_map_tool) | |||
|
|
|||
| def _plan_feature_geom_digitized(self, feature: QgsFeature): | |||
| # NOTE: What if user has changed dock selections while digitizng? | |||
There was a problem hiding this comment.
Hyvä huomio. Näistä kaikista vastaavista voisi tehdä issuen GitHubiin.
| for index in range(self.template_list.count()): | ||
| item = self.template_list.item(index) | ||
| item_text = item.text().lower() | ||
| plan_feature: PlanFeature = item.data(Qt.UserRole) |
There was a problem hiding this comment.
Hyvä tapa olisi luoda kutakin käyttötarkoitusta varten oma UserRole. Käytännössä Qt.UserRole (rolet ylseisestikin) on vaan integer, joka kertoo mistä alkaa käyttäjälle varatut integerarvot (maksimi on Qt.MaxUserRole).
from enum import IntEnum
class CustomDataRole(IntEnum):
FeatureRole = Qt.UserRole
SomeOtherRole = Qt.UserRole +1
...
feature = PlanFeature()
item.setData(CustomDataRole.FeatureRole, feature)There was a problem hiding this comment.
Tehdään tästä asiasta yleinen issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.