Configure 2-Party Review on Github PRs from External Contributors #3660
+45
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachaelSTamakloe
force-pushed
the
2PR
branch
3 times, most recently
from
6fb866e to
37f5143
Compare
RachaelSTamakloe
assigned tpdownes, mr0re1 and rohitramu and unassigned RachaelSTamakloe
rohitramu
approved these changes
Feb 13, 2025
RachaelSTamakloe
force-pushed
the
2PR
branch
from
37f5143 to
cea798a
Compare
RachaelSTamakloe
force-pushed
the
2PR
branch
from
cea798a to
b2c44c0
Compare
mr0re1
reviewed
Feb 18, 2025
mr0re1
approved these changes
Feb 18, 2025
tpdownes
approved these changes
Feb 19, 2025
RachaelSTamakloe
merged commit 0aafdb1
into
GoogleCloudPlatform:develop
11 of 61 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a workflow that configures 2-Party Review on PRs from External Contributors. We define an external contributor as someone who doesn't have write permissions to the Cluster toolkit Github repository. It will require a single approval for PRs created from users with write access, but require two approvals for PRs created by users without write permissions. This PR depends on PR3662 being merged.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.