Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include list of members with write permissions #3662

Merged

Conversation

RachaelSTamakloe
Copy link
Collaborator

@RachaelSTamakloe RachaelSTamakloe commented Feb 10, 2025

This PR adds the list of cluster toolkit users with write access to the Cluster Toolkit github repository. This list will be used to configure 2-Party Review on Github PRs from External Contributors in the workflow defined in PR3660. The workflow will require two members from this list to approve pull requests sent from an external contributor. We define an external contributor as someone who doesn't have write permissions to the Cluster toolkit Github repository.

Members of groups were generated by running the below command:

gh api   \
   -H "Accept: application/vnd.github+json" \
   -H "X-GitHub-Api-Version: 2022-11-28" \
   --paginate /orgs/GoogleCloudPlatform/teams/<TEAM_NAME>/members \
| jq '[.[] | {login}]'

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@RachaelSTamakloe RachaelSTamakloe self-assigned this Feb 10, 2025
@RachaelSTamakloe RachaelSTamakloe marked this pull request as ready for review February 11, 2025 23:38
@RachaelSTamakloe RachaelSTamakloe added the release-chore To not include into release notes label Feb 11, 2025
@RachaelSTamakloe RachaelSTamakloe marked this pull request as draft February 14, 2025 00:08
@RachaelSTamakloe RachaelSTamakloe changed the title Include list of GCP org members Include list of members with write permissions Feb 14, 2025
@RachaelSTamakloe RachaelSTamakloe marked this pull request as ready for review February 14, 2025 21:18
@mr0re1 mr0re1 removed their assignment Feb 18, 2025
@RachaelSTamakloe RachaelSTamakloe merged commit 53cc4a7 into GoogleCloudPlatform:develop Feb 19, 2025
11 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants