Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples(storage transfer): add samples and test cases for storage transfer services #2857

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

mahendra-google
Copy link

Adding samples and tests cases for following storage transfer services:

  • 1. storagetransfer_quickstart
  • 2. storagetransfer_transfer_to_nearline
  • 3. storagetransfer_get_latest_transfer_operation
  • 4. storagetransfer_manifest_request
  • 5. storagetransfer_transfer_from_posix
  • 6. storagetransfer_download_to_posix
  • 7. storagetransfer_transfer_posix_to_posix
  • 8. storagetransfer_create_event_driven_gcs_transfer

…utput message in sample output and related small changes.
…sfer to nearline and check latest transfer operation (#1)
…ole , rewording , removing some unnecessary symbols, few test checks removed related to posix file transfer.
@mahendra-google mahendra-google requested review from a team as code owners December 4, 2024 10:22
@amanda-tarafa
Copy link
Member

amanda-tarafa commented Dec 20, 2024

Just as a heads up, it's unlikely that I can get to this before January.

I'm running the tests though so we at least know whether things are working or not.

@amanda-tarafa amanda-tarafa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 20, 2024
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 20, 2024
@amanda-tarafa
Copy link
Member

Tests are green, thanks. I'll re-review as soon as possible, but likely to be in January.

@amanda-tarafa
Copy link
Member

@mahendra-google There are still a few change requests that haven't been adressed, . Please adresses those, or explain why you shouldn't or ask questions about the change requests if you have them. In particular my comments on the fixture will impact a lot of the test code. I'd prefer to do a pass when things look more definitive. Thanks.

@mahendra-google
Copy link
Author

mahendra-google commented Jan 10, 2025

@mahendra-google There are still a few change requests that haven't been adressed, . Please adresses those, or explain why you shouldn't or ask questions about the change requests if you have them. In particular my comments on the fixture will impact a lot of the test code. I'd prefer to do a pass when things look more definitive. Thanks.

@amanda-tarafa Sorry for delays as I was involved into other high priority tasks that I have been assigned. I will address it soon and will ask questions . Thanks

@amanda-tarafa
Copy link
Member

No rush on my part at all.

@mahendra-google
Copy link
Author

No rush on my part at all.

It's on priority from day 1 and it will be forever. A new resource has been identified for work that I have been assigned I am delegating those tasks to new resource. A KT session is going on. Soon I will be focusing full time on .NET

@amanda-tarafa
Copy link
Member

@mahendra-google Do let me know here when this is ready for review again. No rush on my part, but just know I won't review until you have said so here. Thanks!

@mahendra-google
Copy link
Author

@mahendra-google Do let me know here when this is ready for review again. No rush on my part, but just know I won't review until you have said so here. Thanks!

@amanda-tarafa Yes , I will let you know when this is ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storagetransfer Issues related to the Storage Transfer Service API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants