Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples(storage transfer): add samples and test cases for storage transfer services #9

Open
wants to merge 52 commits into
base: main
Choose a base branch
from

Conversation

mahendra-google
Copy link
Owner

@mahendra-google mahendra-google commented Jan 30, 2025

Adding samples and tests cases for following storage transfer services:

  • 1. storagetransfer_quickstart
  • 2. storagetransfer_transfer_to_nearline
  • 3. storagetransfer_get_latest_transfer_operation
  • 4. storagetransfer_manifest_request
  • 5. storagetransfer_transfer_from_posix
  • 6. storagetransfer_download_to_posix
  • 7. storagetransfer_transfer_posix_to_posix
  • 8. storagetransfer_create_event_driven_gcs_transfer

mahendra-google and others added 30 commits October 9, 2024 02:00
…utput message in sample output and related small changes.
…sfer to nearline and check latest transfer operation (#1)
…ole , rewording , removing some unnecessary symbols, few test checks removed related to posix file transfer.
@mahendra-google
Copy link
Owner Author

@amrik-mahal Internal PR is ready for re-review.

};

// Create a Transfer Service client
StorageTransferServiceClient client = StorageTransferServiceClient.Create();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add exception handling and pass necessary information.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google PR ( PR )

}

// Create a Transfer Service client
StorageTransferServiceClient storageTransfer = StorageTransferServiceClient.Create();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add generic exception handling.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )

EventStream = new EventStream { Name = pubSubId }
};

StorageTransferServiceClient client = StorageTransferServiceClient.Create();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add exception handling.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )

};

// Create a Transfer Service client
StorageTransferServiceClient client = StorageTransferServiceClient.Create();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add expception handling.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )

};

// Create a Transfer Service client
StorageTransferServiceClient client = StorageTransferServiceClient.Create();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add exception handling to handle failure.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )

};

// Create a Transfer Service client
StorageTransferServiceClient client = StorageTransferServiceClient.Create();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add exception handling to handle failure.

};

// Create a Transfer Service client
StorageTransferServiceClient client = StorageTransferServiceClient.Create();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add exception handling to handle failure.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )

Copy link
Collaborator

@amrik-mahal amrik-mahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline comment for files. overall comments and exception handling related findings

@mahendra-google
Copy link
Owner Author

inline comment for files. overall comments and exception handling related findings

@amrik-mahal Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants