-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples(storage transfer): add samples and test cases for storage transfer services #9
base: main
Are you sure you want to change the base?
Conversation
…transfer_transfer_to_nearline.
…b.com/mahendra-google/dotnet-docs-samples into missing_.net_transfer_service_samples
…storagetransfer_transfer_to_nearline.
…or storagetransfer_transfer_to_nearline.
…b.com/mahendra-google/dotnet-docs-samples into missing_.net_transfer_service_samples
…utput message in sample output and related small changes.
…andard output of test log summary.
…test transfer operation.
…sfer to nearline and check latest transfer operation (#1)
…ket using manifest file (#2)
… folder in posix file system (#5)
…ole , rewording , removing some unnecessary symbols, few test checks removed related to posix file transfer.
…estSample.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…gManifestTest.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
@amrik-mahal Internal PR is ready for re-review. |
storagetransfer/api/StorageTransfer.Samples.Tests/CheckLatestTransferOperationTest.cs
Show resolved
Hide resolved
storagetransfer/api/StorageTransfer.Samples.Tests/CreateEventDrivenGcsTransferTest.cs
Show resolved
Hide resolved
}; | ||
|
||
// Create a Transfer Service client | ||
StorageTransferServiceClient client = StorageTransferServiceClient.Create(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add exception handling and pass necessary information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google PR ( PR )
storagetransfer/api/StorageTransfer.Samples.Tests/DownloadToPosixTest.cs
Show resolved
Hide resolved
storagetransfer/api/StorageTransfer.Samples.Tests/StorageTransfer.Samples.Tests.csproj
Show resolved
Hide resolved
storagetransfer/api/StorageTransfer.Samples.Tests/TransferBetweenPosixTest.cs
Show resolved
Hide resolved
storagetransfer/api/StorageTransfer.Samples.Tests/TransferFromPosixTest.cs
Show resolved
Hide resolved
storagetransfer/api/StorageTransfer.Samples.Tests/TransferToNearlineTest.cs
Show resolved
Hide resolved
storagetransfer/api/StorageTransfer.Samples.Tests/TransferUsingManifestTest.cs
Show resolved
Hide resolved
} | ||
|
||
// Create a Transfer Service client | ||
StorageTransferServiceClient storageTransfer = StorageTransferServiceClient.Create(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add generic exception handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )
EventStream = new EventStream { Name = pubSubId } | ||
}; | ||
|
||
StorageTransferServiceClient client = StorageTransferServiceClient.Create(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add exception handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )
}; | ||
|
||
// Create a Transfer Service client | ||
StorageTransferServiceClient client = StorageTransferServiceClient.Create(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add expception handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )
}; | ||
|
||
// Create a Transfer Service client | ||
StorageTransferServiceClient client = StorageTransferServiceClient.Create(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add exception handling to handle failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )
}; | ||
|
||
// Create a Transfer Service client | ||
StorageTransferServiceClient client = StorageTransferServiceClient.Create(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add exception handling to handle failure.
}; | ||
|
||
// Create a Transfer Service client | ||
StorageTransferServiceClient client = StorageTransferServiceClient.Create(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add exception handling to handle failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception handling is not required in samples unless it is a very specific case that is significantly different from normal try catch code block. Please see the reference conversation in google ( PR )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inline comment for files. overall comments and exception handling related findings
|
Adding samples and tests cases for following storage transfer services: