chore: refactor the external reference for SecretManagerSecret #3176
Conversation
yuwenma
changed the title
| } | ||
|
|
||
| type SecretParent struct { | ||
| ProjectID string |
There was a problem hiding this comment.
Are we planning to add to SecretParent? If not we could probably drop the struct as per https://go.dev/play/p/D8y1EF81zyF
|
/lgtm I like that we have isolated the reference code to its own file. I think we should discuss centralizing it into a library. When we get to dealing with something like https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_iamauditconfigs.iam.cnrm.cloud.google.com.yaml#L89 I think we will want a central library. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 9e87297
into
GoogleCloudPlatform:master
Separate identity and reference to different go struct; Use struct and functions to define the meaning and usage of each key component.