Skip to content

Conversation

maqiuyujoyce
Copy link
Collaborator

@maqiuyujoyce maqiuyujoyce commented Oct 13, 2025

BRIEF Change description

Fixes #5334

WHY do we need this change?

Special notes for your reviewer:

Does this PR add something which needs to be 'release noted'?


  • Reviewer reviewed release note.

Additional documentation e.g., references, usage docs, etc.:


Intended Milestone

Please indicate the intended milestone.

  • Reviewer tagged PR with the actual milestone.

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maqiuyujoyce. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maqiuyujoyce maqiuyujoyce force-pushed the 202510-analyticsaccount branch from bfc3e6f to 8750cd0 Compare October 13, 2025 11:10
@maqiuyujoyce maqiuyujoyce changed the title [WIP] Support AnalyticsAccount (Alpha) Support AnalyticsAccount (Alpha) Oct 13, 2025
Copy link
Collaborator

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this PR into the follow sub PRs:

  1. crud, log and MockGCP
  2. API, Mapper and fuzzer
  3. controller (*_identity, *_reference), and fixture tests

@maqiuyujoyce
Copy link
Collaborator Author

Please split this PR into the follow sub PRs:

  1. crud, log and MockGCP
  2. API, Mapper and fuzzer
  3. controller (*_identity, *_reference), and fixture tests

Will split the PR.
Though this resource doesn't have gcloud support so we cannot support script test for it.

@maqiuyujoyce
Copy link
Collaborator Author

Replaced by #5422 #5423 and #5424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add AnalyticsAccount as a KRM-native resource (Alpha)

3 participants