-
Notifications
You must be signed in to change notification settings - Fork 292
Support mockgcp for AnalyticsAccount #5422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Support mockgcp for AnalyticsAccount #5422
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e98d38e
to
1943105
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean bumping the go mod in mockgcp (rather than the REPO_ROOT go.mod)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Added the dependency in the mockgcp folder.
Tried to remove it from the root go.mod but it got added back automatically after make ensure
so I assume that this indirect dependency is needed
./third_party/googleapis/google/iam/v2/*.proto \ | ||
./third_party/googleapis/google/logging/v2/*.proto | ||
./third_party/googleapis/google/logging/v2/*.proto \ | ||
./third_party/googleapis/google/analytics/admin/v1alpha/*.proto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alpha is very experimental version. Suggest at least using v1beta?
https://developers.google.com/analytics/devguides/config/admin/v1/rpc/google.analytics.admin.v1beta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Mentioned in description): We use the alpha version (googleapis/google/analytics/admin/v1alpha/*.proto) because only v1alpha is supported in the latest version of Cloud Go client (https://pkg.go.dev/cloud.google.com/go/[email protected]/admin/apiv1alpha), and the proto version needs to match the client code version in the mockgcp.
We can bump to v1beta once the Go client supports it.
1943105
to
a13dfc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, @yuwenma . Comments addressed.
./third_party/googleapis/google/iam/v2/*.proto \ | ||
./third_party/googleapis/google/logging/v2/*.proto | ||
./third_party/googleapis/google/logging/v2/*.proto \ | ||
./third_party/googleapis/google/analytics/admin/v1alpha/*.proto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Mentioned in description): We use the alpha version (googleapis/google/analytics/admin/v1alpha/*.proto) because only v1alpha is supported in the latest version of Cloud Go client (https://pkg.go.dev/cloud.google.com/go/[email protected]/admin/apiv1alpha), and the proto version needs to match the client code version in the mockgcp.
We can bump to v1beta once the Go client supports it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Added the dependency in the mockgcp folder.
Tried to remove it from the root go.mod but it got added back automatically after make ensure
so I assume that this indirect dependency is needed
BRIEF Change description
Fixes part 1 of #5334
Note that:
WHY do we need this change?
Special notes for your reviewer:
Does this PR add something which needs to be 'release noted'?
Additional documentation e.g., references, usage docs, etc.:
Intended Milestone
Please indicate the intended milestone.
Tests you have done
make ready-pr
to ensure this PR is ready for review.