Skip to content

✅ Fixes flaky: test_guest_user_is_not_garbage_collected #7609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pcrespov
Copy link
Member

What do these changes do?

image

image

Related issue/s

How to test

cd services/web/server
make install-dev
 pytest -vv tests/unit -k test_guest_user_is_not_garbage_collected 

Dev-ops

@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Apr 29, 2025
@pcrespov pcrespov self-assigned this Apr 29, 2025
@pcrespov pcrespov added this to the Pauwel Kwak milestone Apr 29, 2025
@pcrespov pcrespov marked this pull request as ready for review April 29, 2025 12:28
@pcrespov pcrespov force-pushed the is7005/test_guest_user_is_not_garbage_collected branch from 93d940d to 0355879 Compare April 29, 2025 12:28
@pcrespov pcrespov enabled auto-merge (squash) April 29, 2025 12:28
@pcrespov pcrespov changed the title Fixes flaky: test_guest_user_is_not_garbage_collected ✅ Fixes flaky: test_guest_user_is_not_garbage_collected Apr 29, 2025
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov force-pushed the is7005/test_guest_user_is_not_garbage_collected branch from f9c4123 to 49eacc2 Compare April 29, 2025 12:36
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks but I think moving the link away is not helpful, it is useful to have it in the PR template

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (85a2e9d) to head (9e7a03a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7609      +/-   ##
==========================================
- Coverage   87.75%   84.17%   -3.58%     
==========================================
  Files        1771      683    -1088     
  Lines       68339    32166   -36173     
  Branches     1134      170     -964     
==========================================
- Hits        59968    27075   -32893     
+ Misses       8057     5033    -3024     
+ Partials      314       58     -256     
Flag Coverage Δ
integrationtests 65.09% <ø> (-0.03%) ⬇️
unittests 87.46% <ø> (+0.51%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.41% <ø> (-8.31%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.13% <ø> (-13.03%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.06% <ø> (-1.10%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 86.04% <ø> (-0.07%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a2e9d...9e7a03a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 29, 2025
@pcrespov
Copy link
Member Author

@mergify queue

Copy link
Contributor

mergify bot commented Apr 29, 2025

queue

🛑 The pull request has been merged manually

The pull request has been merged manually at 3db0e34

@pcrespov pcrespov merged commit 3db0e34 into ITISFoundation:master Apr 29, 2025
93 of 96 checks passed
@pcrespov pcrespov deleted the is7005/test_guest_user_is_not_garbage_collected branch April 29, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test_guest_user_is_not_garbage_collected[32]
5 participants