Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema: don't limit browser_session.user_agent to 4096 chars #239

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Schema: don't limit browser_session.user_agent to 4096 chars #239

merged 1 commit into from
Jul 22, 2024

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Jul 15, 2024 •
edited
Loading

@Al2Klimov Al2Klimov requested a review from ncosta-ic July 15, 2024 08:34
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 15, 2024
ncosta-ic
ncosta-ic previously approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@ncosta-ic ncosta-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Shouldn't cause any issues as we already used the text type before the limitation.

@Al2Klimov Al2Klimov force-pushed the browser_session-user_agent-4k branch from 9ce584d to a04da81 Compare July 15, 2024 10:11
@Al2Klimov Al2Klimov mentioned this pull request Jul 15, 2024
Merged
6 tasks
@Al2Klimov Al2Klimov force-pushed the browser_session-user_agent-4k branch from a04da81 to 6971952 Compare July 22, 2024 10:09
@Al2Klimov Al2Klimov requested a review from yhabteab July 22, 2024 10:32
@julianbrost julianbrost merged commit 5492d74 into main Jul 22, 2024
26 checks passed
@julianbrost julianbrost deleted the browser_session-user_agent-4k branch July 22, 2024 13:35
@Al2Klimov Al2Klimov mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

@yhabteab yhabteab yhabteab approved these changes

@ncosta-ic ncosta-ic ncosta-ic left review comments

Assignees
No one assigned
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Al2Klimov @julianbrost @yhabteab @ncosta-ic