Skip to content

Schema: don't limit browser_session.user_agent to 4096 chars #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schema/mysql/schema.sql
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ CREATE INDEX idx_incident_history_time_type ON incident_history(time, type) COMM
CREATE TABLE browser_session (
php_session_id varchar(256) NOT NULL,
username varchar(254) NOT NULL COLLATE utf8mb4_unicode_ci,
user_agent varchar(4096) NOT NULL,
user_agent text NOT NULL,
authenticated_at bigint NOT NULL,

CONSTRAINT pk_browser_session PRIMARY KEY (php_session_id)
Expand Down
1 change: 1 addition & 0 deletions schema/mysql/upgrades/035.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE browser_session MODIFY COLUMN user_agent text NOT NULL;
2 changes: 1 addition & 1 deletion schema/pgsql/schema.sql
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ COMMENT ON INDEX idx_incident_history_time_type IS 'Incident History ordered by
CREATE TABLE browser_session (
php_session_id varchar(256) NOT NULL,
username citext NOT NULL,
user_agent varchar(4096) NOT NULL,
user_agent text NOT NULL,
authenticated_at bigint NOT NULL,

CONSTRAINT pk_browser_session PRIMARY KEY (php_session_id),
Expand Down
1 change: 1 addition & 0 deletions schema/pgsql/upgrades/035.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE browser_session ALTER COLUMN user_agent TYPE text;
Loading