Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create introducing-metrics-in-innersource.md #497

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Trueblueaddie
Copy link
Contributor

No description provided.

@spier
Copy link
Member

spier commented Dec 4, 2022

hi @Trueblueaddie. Thanks for adding this pattern.

There is a pattern with the same name here:
https://github.com/Trueblueaddie/InnerSourcePatterns/blob/patch-2/patterns/1-initial/introducing-metrics-in-innersource.md

If yours is a new pattern, I would suggest to pick a different name, so that we can differentiate both patterns.

I would further suggest to move this pattern to folder patterns/1-initial. That way we can give this pattern some time to be vetted by the community before it goes live in our online book.

Please let me know if you need help with any of this, I would be happy to.

@Trueblueaddie
Copy link
Contributor Author

I've reviewed the markdownlint and attempted to correct the spacing concerns. I'm not sure exactly what is necessary to be adjusted here.

@Trueblueaddie
Copy link
Contributor Author

@spier thanks for calling that out. I'll see if mine has anything to add the one you shared.

@spier spier added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Dec 5, 2022
fioddor added a commit to fioddor/InnerSourcePatterns that referenced this pull request Feb 24, 2023
Retrieve known instance from InnerSourceCommons#497
spier added a commit that referenced this pull request Mar 10, 2023
…nstead of new patterns) (#526)

* All forces mentioned were against the pattern. I'm adding some in favor for balance and better justification.
* Add known instance - based on #497 
* Structure the solution. Mention outliers (thank you, Addie).
* Links to metrics references that are mentioned in the text.

Co-authored-by: Trueblueaddie <[email protected]>
Co-authored-by: Sebastian Spier <[email protected]>
@spier
Copy link
Member

spier commented Mar 10, 2023

@fioddor based on #526 I understand that we can close this PR here as duplicate, right?

Just saw that this PR mentions two other authors as well. I know Daniel but Alberto is possibly from Santander Bank itself:
Alberto Pérez García-Plaza
Daniel Izquierdo Cortázar

Should we add those two to the "Acknowledgement" on the pattern?

@fioddor
Copy link
Contributor

fioddor commented Mar 10, 2023

@fioddor based on #526 I understand that we can close this PR here as duplicate, right?

I guess so. WDYT, @Trueblueaddie?

Just saw that this PR mentions two other authors as well. I know Daniel but Alberto is possibly from Santander Bank itself:

Alberto is a former bitergian and currently a university professor.

Should we add those two to the "Acknowledgement" on the pattern?

Yes.

spier added a commit that referenced this pull request Mar 11, 2023
@spier
Copy link
Member

spier commented Mar 11, 2023

Added further acknowledgements via bf274fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants