Introducing Metrics in InnerSource: Merge PR497 and PR501 upstream (instead of new patterns) #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All forces mentioned were against the pattern. I'm adding some in favor for balance and better justification.
fioddor
requested review from
lenucksi,
NewMexicoKid,
cewilliams,
spier and
robtuley
as code owners
Retrieve known instance from InnerSourceCommons#497
Structure the solution. Mention outliers (than you, Addie).
fioddor
changed the title
spier
reviewed
Mar 10, 2023
There was a problem hiding this comment.
@fioddor thanks for consolidating the different PRs related to this pattern. You approach sounds good to me.
I left some comments inline. Will merge the straightforward fixes myself.
Aside:
As you are adding a Known Instance to this pattern, we could upgrade this pattern to Structured soon. I suggest to do that via a separate PR though, once all the others are merged or closed. That allows us to do one more proper review and check the pattern against all requirements of the Structured level.
Links to metrics references that are mentioned in the text. Co-authored-by: Sebastian Spier <[email protected]>
Minor style fixes. Co-authored-by: Sebastian Spier <[email protected]>
spier
changed the title
spier
added
1-initial
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR497 duplicates this pattern.
PR501 might extend this pattern instead of creating a new one.
This MR intends to capture the useful bits and merge them upstream so PR497 and/or PR501 can be withdrawn.