-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chinese set as language by default #521
Comments
For me I see that happen when first visiting a page that doesn't exist - e.g. https://innersourcecommons.org/learning-path/ Thereafter I am always on Chinese pages. Here is a video: innersourcecommons.org.language.bug-20230426_152333-Meeting.Recording.mp4 |
Sorry for the late response, let me address the issue |
Thanks for taking a look, @yuhattor ❗ |
That is odd! |
In conclusion, hugo does not support multilingual 404 pages, so I found that a hack is necessary in the current situation. I created the PR #567 here. I added a little processing at build worklow |
Please review the PR! |
Great that you found something! Will take a look sometime this week. |
@yuhattor are you sure that this issue is caused by the 404 pages? Here is one other example that I found today that seems unrelated to 404 pages: Steps:
|
Thank you The redirection is suspicious. |
I think this is a pretty deep-rooted problem, and I'm looking at hugo's source code, but I don't know much about it yet, including the fact that I'm not a go pro. |
That's interesting - it feels like there should be some way to get this, but I don't know how our localization was set up and if it conflicts with any assumptions from Hugo. Thanks for checking this out! |
Within the announcement files it seems to only be occurring with files that use aliases. Ex: |
Describe the bug
When opening pages on innersourcecommons.org, the chinese language is chose as the default language regardless of the browser language. This behaviour was confirmed by multiple users using different browsers. Example to reproduce: https://innersourcecommons.org/learn
Expected behavior
The language should be chosen based on the browser language with English being the default, if the browser language doesn't match any of the languages supported by the site.
/FYI @rrrutledge , @dellagustin
The text was updated successfully, but these errors were encountered: