ENH: Update MINC to fdf1845#5873
Merged
blowekamp merged 3 commits intoInsightSoftwareConsortium:mainfrom Mar 6, 2026
Merged
Conversation
Code extracted from:
https://github.com/BIC-MNI/libminc.git
at commit fdf184521d94a067d20c48ea3ffafccee99c4a8d (fdf1845).
Member
Author
|
This update addresses a build error with SimpleITK, by using cmake_minimum_required with a version range for policies. |
thewtex
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the vendored MINC (libminc) third-party library from commit
e5064e43(2026-02-09) to commitfdf18452(2026-02-21).Upstream commit: BIC-MNI/libminc@fdf1845
Changes
config.h.cmake: Various configuration updates (80 lines changed)CMakeLists.txt: Upstream switched toGNUInstallDirsdefaults (${CMAKE_INSTALL_LIBDIR}instead oflib${LIB_SUFFIX}forCMAKE_INSTALL_RPATH). ITK's local patch preserving${LIBMINC_EXTERNAL_LIB_PREFIX}minc2forVOLUME_IO_LIBRARYwas carried forward.Conflict Resolution
There was a single merge conflict in
Modules/ThirdParty/MINC/src/libminc/CMakeLists.txt. The upstream change used${CMAKE_INSTALL_LIBDIR}(GNUInstallDirs) forCMAKE_INSTALL_RPATH, while ITK had a local patch forVOLUME_IO_LIBRARY. Both changes were preserved in the resolution.Notes
update-third-partyskill.