Skip to content

Optimize sentry integration #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Optimize sentry integration #2449

wants to merge 3 commits into from

Conversation

kneerose
Copy link
Contributor

@kneerose kneerose commented Dec 2, 2024 •
edited
Loading

List of changes

  • Make sentry initialize optional for frontend and backend
  • only register the sentry if the "sentry dsn" is available on frontend and sentryEnv is not "qa" in the backend

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip December 2, 2024 07:11
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ All checks succeeded

@kneerose kneerose mentioned this pull request Dec 2, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

✅ All checks succeeded

@kneerose kneerose force-pushed the feat/optional-sentry-integration branch from ce8b20e to c35033b Compare December 11, 2024 08:32
@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

@kneerose
Copy link
Contributor Author

@MSzalowski , could you please review this? Feel free to make any updates or changes as needed.

@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

@mesudip
Copy link
Contributor

mesudip commented Jan 2, 2025

@MSzalowski , can you review and determine whether or not it is still relevant?

@MSzalowski
Copy link
Contributor

@kneerose Can we merge this PR?

mesudip
mesudip requested changes Jan 23, 2025
View reviewed changes
@kneerose kneerose force-pushed the feat/optional-sentry-integration branch from c35033b to 464111c Compare January 30, 2025 10:07
@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

@kneerose kneerose requested a review from mesudip January 30, 2025 11:02
@kneerose kneerose requested a review from MSzalowski January 31, 2025 06:07
@kneerose kneerose requested a review from placek January 31, 2025 06:07
@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

@github-actions GitHub Actions
Copy link
Contributor

✅ All checks succeeded

@kneerose
Copy link
Contributor Author

@MSzalowski can you review this again? also please look at this ticket
#2776

mesudip
mesudip approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mesudip
Copy link
Contributor

mesudip commented Mar 18, 2025

Assigned to @MSzalowski for backend changes

Todo

  • When sentrydsn is not set in config file or is empty then sentry will be disabled.

@kneerose kneerose linked an issue May 19, 2025 that may be closed by this pull request
Backend doesn't log on console #2776
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@placek placek placek approved these changes

@mesudip mesudip mesudip approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@adgud adgud Awaiting requested review from adgud

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees

@MSzalowski MSzalowski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Backend doesn't log on console

4 participants

@kneerose @mesudip @MSzalowski @placek