Skip to content

Optimize sentry integration #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Optimize sentry integration #2449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c31d3e
chore: conditionally initialize Sentry based on DSN availability
kneerose Jan 30, 2025
464111c
feat: register Sentry only if sentryEnv is not 'qa'
kneerose Jan 30, 2025
a5b2432
chore: remove VITE_SENTRY_DSN build argument check from Dockerfile
kneerose Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion govtool/backend/app/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ exceptionHandler vvaConfig sentryService mRequest exception = do
let env = sentryEnv vvaConfig
case mRequest of
Nothing -> return ()
Just _ -> register
Just _ -> when (env /= "qa") $ register
sentryService
"vva.be"
Error
Expand Down
1 change: 0 additions & 1 deletion govtool/frontend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ RUN \
: "${VITE_METADATA_API_URL:?Build argument VITE_METADATA_API_URL is not set}" && \
: "${VITE_GTM_ID:?Build argument VITE_GTM_ID is not set}" && \
: "${VITE_NETWORK_FLAG:?Build argument VITE_NETWORK_FLAG is not set}" && \
: "${VITE_SENTRY_DSN:?Build argument VITE_SENTRY_DSN is not set}" && \
: "${NPMRC_TOKEN:?Build argument NPMRC_TOKEN is not set}" && \
: "${VITE_USERSNAP_SPACE_API_KEY:?Build argument VITE_USERSNAP_SPACE_API_KEY is not set}" && \
: "${VITE_IS_PROPOSAL_DISCUSSION_FORUM_ENABLED:?Build argument VITE_IS_PROPOSAL_DISCUSSION_FORUM_ENABLED is not set}" && \
Expand Down
46 changes: 24 additions & 22 deletions govtool/frontend/src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,28 +24,30 @@ const tagManagerArgs = {

TagManager.initialize(tagManagerArgs);

Sentry.init({
dsn: import.meta.env.VITE_SENTRY_DSN,
environment: import.meta.env.VITE_APP_ENV,
release: version,
integrations: [
Sentry.browserTracingIntegration(),
Sentry.replayIntegration(),
],
tracesSampleRate: 1.0,
replaysSessionSampleRate: 0.1,
replaysOnErrorSampleRate: 1.0,
beforeSend(event) {
window.dataLayer = window.dataLayer || [];
window.dataLayer.push({
event: "sentryEvent",
sentryEventId: event?.event_id || "default_event_id",
sentryErrorMessage:
event?.exception?.values?.[0]?.value || "Unknown Error",
});
return event;
},
});
if (import.meta.env.VITE_SENTRY_DSN) {
Sentry.init({
dsn: import.meta.env.VITE_SENTRY_DSN,
environment: import.meta.env.VITE_APP_ENV,
release: version,
integrations: [
Sentry.browserTracingIntegration(),
Sentry.replayIntegration(),
],
tracesSampleRate: 1.0,
replaysSessionSampleRate: 0.1,
replaysOnErrorSampleRate: 1.0,
beforeSend(event) {
window.dataLayer = window.dataLayer || [];
window.dataLayer.push({
event: "sentryEvent",
sentryEventId: event?.event_id || "default_event_id",
sentryErrorMessage:
event?.exception?.values?.[0]?.value || "Unknown Error",
});
return event;
},
});
}

ReactDOM.createRoot(document.getElementById("root") as HTMLElement).render(
<React.StrictMode>
Expand Down
Loading