-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONOTMERGE] Switch llvm source build to v20 #57658
Conversation
PkgEval got restarted: @nanosoldier Only one job ahead of this, so it should report within 2 days. |
The build failed:
PkgEval is currently using the latest rootfs, https://github.com/JuliaCI/rootfs-images/releases/tag/v7.10. I guess we'll need to upgrade from bullseye to bookworm, https://github.com/JuliaCI/rootfs-images/blob/e7be8086ff1285b0f333ca72884977d01aed0e1f/src/build_img/debian.jl#L17. |
You can download cmake with |
I forgot we added an invocation to the download cmake script for the source build, JuliaCI/julia-buildkite@552037b. |
@maleadt would it be easy to get this fixed otherwise I'll start the llvm yggy build? |
Can't you run the download cmake script as part of the build script in this PR? This is just for testing anyway. |
Yep, ignore me then tim, I'll do that. |
Let's see if this works @nanosoldier |
I suspect it's missing some package, the source build uses the llvm-passes rootfs image. |
|
Hmm, this just seems like a llvm bug where it's not specifying the path to zlib when linking with libLLVM. |
ea8c8b5
to
3d11791
Compare
Let's try this one more time @nanosoldier |
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed2 packages crashed only on the current version.
✖ Packages that failed7 packages failed only on the current version.
673 packages failed on the previous version too. ✔ Packages that passed tests10 packages passed tests only on the current version.
3665 packages passed tests on the previous version too. ~ Packages that at least loaded1 packages successfully loaded only on the current version.
1987 packages successfully loaded on the previous version too. ➖ Packages that were skipped altogether4034 packages were skipped on the previous version too. |
That's remarkably few new failures. |
3d11791
to
f12db52
Compare
All looked good, but let's confirm on the newer commit from our llvm fork. @nanosoldier |
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed2 packages crashed only on the current version.
✖ Packages that failed7 packages failed only on the current version.
606 packages failed on the previous version too. ✔ Packages that passed tests4 packages passed tests only on the current version.
3334 packages passed tests on the previous version too. ~ Packages that at least loaded1737 packages successfully loaded on the previous version too. ➖ Packages that were skipped altogether4691 packages were skipped on the previous version too. |
Might make sense to re-run PkgEval once #57785 is merged? |
Good to rerun now |
1b962d6
to
48fdcdb
Compare
@nanosoldier |
Hmm, this x86 darwin failure looks real given it doesn't occur on #57792.
|
The package evaluation job you requested has completed - possible new issues were detected. Report summary❗ Packages that crashed2 packages crashed only on the current version.
1 packages crashed on the previous version too. ✖ Packages that failed19 packages failed only on the current version.
1449 packages failed on the previous version too. ✔ Packages that passed tests20 packages passed tests only on the current version.
5049 packages passed tests on the previous version too. ~ Packages that at least loaded16 packages successfully loaded only on the current version.
2923 packages successfully loaded on the previous version too. ➖ Packages that were skipped altogether1 packages were skipped only on the current version.
905 packages were skipped on the previous version too. |
Try to debug issue at JuliaLang#57658 (comment)
This is for testing with pkgeval before we have built on yggdrasil
@nanosoldier
runtests(configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1", "USE_BINARYBUILDER_LLVM=0"],), vs_configuration = (buildflags=["LLVM_ASSERTIONS=1", "FORCE_ASSERTIONS=1"],))