REPL: use @async
to run repl keymap etc. not @spawn :interactive
#57730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The execution of regular user input happens outside of this scope, but if the user pastes in multiple prompts then those prompts are executed within these tasks.
On a system with no interactive pool, but a > 1 default one,
@spawn :interactive
has free reign to schedule onto any:default
thread. (Perhaps it shouldn't and just spawn onto 1??)Some user code doesn't like being run on threads other than the main thread, like GLFW, so weird errors can happen when code is pasted in that doesn't happen otherwise, so this reverts these back to
@async
.The main task is already sticky for many reasons, so I don't think this is a loss.