Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL: use @async to run repl keymap etc. not @spawn :interactive #57730

Closed
wants to merge 1 commit into from
Closed

REPL: use @async to run repl keymap etc. not @spawn :interactive #57730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stdlib/REPL/src/LineEdit.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2927,7 +2927,7 @@ keymap_data(ms::MIState, m::ModalInterface) = keymap_data(state(ms), mode(ms))

function prompt!(term::TextTerminal, prompt::ModalInterface, s::MIState = init_state(term, prompt))
Base.reseteof(term)
t1 = Threads.@spawn :interactive while true
t1 = @async while true
wait(s.async_channel)
status = @lock s.line_modify_lock begin
fcn = take!(s.async_channel)
Expand All @@ -2942,7 +2942,7 @@ function prompt!(term::TextTerminal, prompt::ModalInterface, s::MIState = init_s
old_state = mode(s)
# spawn this because the main repl task is sticky (due to use of @async and _wait2)
# and we want to not block typing when the repl task thread is busy
t2 = Threads.@spawn :interactive while true
t2 = @async while true
eof(term) || peek(term) # wait before locking but don't consume
@lock s.line_modify_lock begin
s.n_keys_pressed += 1
Expand Down