Fix some issues with llvm source build #57792
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The build fails if any runtime is enabled as `LLVM_ENABLE_RUNTIMES` will start with `;` which it seems to interpret as a runtime whose name is the empty string. - When llvm links against libLLVM, this fails as some of the compilers on CI set a sysroot causing zlib to not be found, see llvm/llvm-project#131119. - Also, fix freebsd build by compiling statically linked code with `-fPIC`.
We don't use this on yggdrasil, so shouldn't be necessary.
This reverts commit 7876878.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM_ENABLE_RUNTIMESwill start with;which it seems to interpret as a runtime whose name is the empty string.-fPIC.