Skip to content

refactor: combine date-suffixed rewards table into one table #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

refactor: combine date-suffixed rewards table into one table #426

wants to merge 27 commits into from

Conversation

@seanmcgary
Copy link
Member

@seanmcgary seanmcgary commented Jul 16, 2025 •
edited by bdchatham
Loading

Description

Refactoring date-suffixed rewards table names into one combined table. For example,

gold_10_avs_od_reward_amounts_2025_01_27
                                           --------> rewards_gold_10_avs_od_reward_amounts
gold_10_avs_od_reward_amounts_2025_01_28

This PR also removes rewards_staging table, as it became redundant with the rewards_final.

Type of change

  • Refactor (non-breaking change which does not add or remove functionality)

How Has This Been Tested?

  1. ran this code on the full snapshot and let it run until the new rewards was generated.
  2. ran this code on the slim snapshot and run rewards from 2024 and then from 2025.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@seanmcgary seanmcgary requested a review from a team as a code owner July 16, 2025 15:36
@serichoi65 serichoi65 force-pushed the sm-rewardsTablePerfClone branch 2 times, most recently from e86ff7a to 61c79ba Compare August 4, 2025 05:18
@serichoi65 serichoi65 force-pushed the sm-rewardsTablePerfClone branch 2 times, most recently from a3e054b to 8afcef0 Compare August 22, 2025 18:59
@serichoi65 serichoi65 changed the title WIP: rewards perf updates refactor: combine date-suffixed rewards table into one table Aug 22, 2025
@serichoi65 serichoi65 force-pushed the sm-rewardsTablePerfClone branch from f2e24e6 to d31e3ca Compare August 26, 2025 20:42
@serichoi65 serichoi65 force-pushed the sm-rewardsTablePerfClone branch 3 times, most recently from 75f2076 to c1ceb21 Compare September 22, 2025 00:42
@serichoi65 serichoi65 force-pushed the sm-rewardsTablePerfClone branch from 9445144 to f013732 Compare September 22, 2025 21:51
@serichoi65 serichoi65 force-pushed the sm-rewardsTablePerfClone branch from 941b2f4 to 08d10c1 Compare October 1, 2025 19:58
seanmcgary and others added 16 commits October 14, 2025 15:50
@seanmcgary @serichoi65
wip - combined rewards tables
b6fc5fa
@seanmcgary @serichoi65
rename migrations, add missing tables
d48e51e
@seanmcgary @serichoi65
pass rewardSnapshotStatus.id to each rewards generator function
d362ebc
@serichoi65
add snapshotId to rewardsTable and delete by ID
330b13f
@serichoi65
update DeleteCorruptedRewardsFromBlockHeight
7eeb365
@serichoi65
fix column names to match table definition
96a2e5b
@seanmcgary @serichoi65
refactor all rewards tables
9ddeea5 
refactor all tables and add tests

stuff
@serichoi65
process the migration in chunks
91fa806
@serichoi65
update on conflict in query
35521b7 
hopefully working

chnge back to do nothing

rewards

working?

remove unused function

rename migration file
@serichoi65
remove staging table
2ba3522 
simplify code

fix test

remove old staging tables
@serichoi65
update stakerOperators table with new rewards tables
2104627
@serichoi65
fix rewards functions
11aa165
@serichoi65
use delta strategy to use less data during rewards generation
da8f05e 
delta from its persistent tables

remove gold_staging

remove on conflict

move staging data to gold_table;

remove filter id and optimize left join with gold table

group by

don't remove temp tables

fix missing earners

cutoffdate

fix table 5

fix table 4 and 5

remove restrictive filter on table 5

fix

fix

fix temp file

fix table 2

fix table 5

table 5

conservative table 5
@serichoi65
use delta strategy on stakerOperators tables
710e8de
@serichoi65
fix typo
e4ce547
@serichoi65
fix typo
9ae56f1
@serichoi65 serichoi65 force-pushed the sm-rewardsTablePerfClone branch from 9dad0ee to 66bb0cf Compare October 14, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xrajath 0xrajath Awaiting requested review from 0xrajath 0xrajath is a code owner automatically assigned from Layr-Labs/sidecar

@serichoi65 serichoi65 Awaiting requested review from serichoi65 serichoi65 is a code owner automatically assigned from Layr-Labs/sidecar

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seanmcgary @serichoi65